Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hackerone] Tor DNS issue #13527

Closed
diracdeltas opened this issue Jan 12, 2021 · 1 comment · Fixed by brave/brave-core#7769
Closed

[hackerone] Tor DNS issue #13527

diracdeltas opened this issue Jan 12, 2021 · 1 comment · Fixed by brave/brave-core#7769
Assignees
@diracdeltas @darkdh
Labels
OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include security
Milestone
1.20.x - Release #2

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jan 12, 2021 •
edited
Loading

https://hackerone.com/reports/1077022

related: #4257. it appears this was a known issue at least in the muon days. unclear if it was ever fixed in brave-core.

UPDATE: cause was cname adblocking, so this is a regression, not an earlier issue.
@diracdeltas diracdeltas self-assigned this Jan 12, 2021
@darkdh darkdh self-assigned this Jan 27, 2021
@darkdh darkdh mentioned this issue Feb 2, 2021
Merged
23 tasks
@darkdh darkdh added this to the 1.22.x - Nightly milestone Feb 4, 2021
@brave-builds brave-builds mentioned this issue Feb 10, 2021
Merged
7 tasks
@mcgroarty mcgroarty mentioned this issue Feb 19, 2021
Open
@bbondy bbondy mentioned this issue Feb 19, 2021
Merged
7 tasks
@diracdeltas diracdeltas mentioned this issue Feb 19, 2021
Closed
@LaurenWags LaurenWags mentioned this issue Feb 19, 2021
Closed
@stephendonner
Copy link

stephendonner commented Feb 19, 2021 •
edited
Loading

Verified FIXED on 1.20.108 using the testplan in brave/brave-core#7769, on:

Brave | 1.20.108 Chromium: 88.0.4324.182 (Official Build) (x86_64)
Revision | 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS
macOS Version 11.2.1 (Build 20D74)

Brave | 1.20.108 Chromium: 88.0.4324.182 (Official Build) (64-bit)
Revision73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS | Windows 10 OS Version 2009 (Build 21318.1000)

Verified that in both the DoH off and DoH enabled cases, in Private with Tor tabs, I didn't see DNS-lookup entries for tools.ietf.org via the DNS filter in Wireshark.

macOS 11.2.1 (Big Sur)

Screen Shot 2021-02-19 at 2 57 28 PM

Screen Shot 2021-02-19 at 2 55 27 PM

Windows 10

@NullHypothesis NullHypothesis mentioned this issue May 25, 2021
Open
@evilaliv3 evilaliv3 mentioned this issue Nov 29, 2021
Closed
@iefremov iefremov mentioned this issue Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diracdeltas diracdeltas

@darkdh darkdh

Labels
OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include security
Projects
None yet
Milestone
1.20.x - Release #2
Development

Successfully merging a pull request may close this issue.

Fix Tor dns leak brave/brave-core
5 participants
@stephendonner @diracdeltas @kjozwiak @darkdh and others