Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White space #13570

Closed
ghost opened this issue Jan 14, 2021 · 4 comments
Closed

White space #13570

ghost opened this issue Jan 14, 2021 · 4 comments
Labels
closed/not-actionable OS/Android Fixes related to Android browser functionality

Comments

@ghost
Copy link

ghost commented Jan 14, 2021

Description on m.bdnews24.com on mobile there is a white space at top where ad is there

Steps to reproduce

  1. Go to m.bdnews24.com on mobile
  2. Check at top

Actual result

Screenshot_20210114-184502_Brave

Expected result

There should be no whitespace like when adguard extension is used

Issue reproduces how often

Easily reproduced

Version/Channel Information:

all
  • Can you reproduce this issue with the current Play Store version?
  • yes
  • Can you reproduce this issue with the current Play Store Beta version?
  • don't know
  • Can you reproduce this issue with the current Play Store Nightly version?
  • don't know

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet): phone
  • Android version: 9.0

Brave version

1.18.78

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • no
  • Does the issue resolve itself when disabling Brave Rewards?
  • no
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@ghost ghost added the OS/Android Fixes related to Android browser functionality label Jan 14, 2021
@ghost
Copy link
Author

ghost commented Jan 14, 2021

Same with theverge.com

Edit: this goes away when i enable block scripts
But why can't i enable the block scripts globally on android? Would love that feature

Screenshot_20210114-190649_Brave

@ryanbr
Copy link

ryanbr commented Jan 15, 2021

@Bhooty #13070 & brave/brave-core#6735

I'll close this, when cosmetic filtering lands in Android it'll fix the whitespace issues.

@ryanbr ryanbr closed this as completed Jan 15, 2021
@ghost
Copy link
Author

ghost commented Jan 15, 2021

@Bhooty #13070 & brave/brave-core#6735

I'll close this, when cosmetic filtering lands in Android it'll fix the whitespace issues.

thought it arrived but why can't i enable scripts blocking globally in android? is that not available or I am missing something :)

@ryanbr
Copy link

ryanbr commented Jan 15, 2021

Not available, the script blocking on android (compared to desktop) isn't quite featureful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/not-actionable OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

1 participant