-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] Even more strict on address bar for IPNS #13874
Labels
feature/web3/ipfs
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Test-Plan-Required
QA/Yes
release-notes/include
security
Milestone
Comments
bbondy
added
security
priority/P3
The next thing for us to work on. It'll ride the trains.
OS/Desktop
labels
Feb 1, 2021
23 tasks
@spylogsster mind adding a test plan for this and #13873? Thanks! |
@stephendonner same as here #13873 (comment) |
@stephendonner you mean for DNSLink names other than
|
Verified
Steps:
Verification passed on
Verified the above test plan Verified
Steps:
|
LaurenWags
changed the title
Even more strict on address bar for IPNS
[Security] Even more strict on address bar for IPNS
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/web3/ipfs
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Test-Plan-Required
QA/Yes
release-notes/include
security
This issue #13872 makes it so we only use ipns:// and ipfs:// for configured gateways.
This issue #13873 is for being more strict for
ipfs://
.For IPNS, once we have DNSLink, we should only replace when there's a valid CID and when DNSLink has no information for the name being used.
The text was updated successfully, but these errors were encountered: