Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards modal for "BAT not supported in your region" has malformed error message #13997

Closed
emerick opened this issue Feb 5, 2021 · 2 comments · Fixed by brave/brave-core#10469
Assignees
Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@emerick
Copy link
Contributor

emerick commented Feb 5, 2021

If BAT is not currently supported in your region, Rewards will display a modal to that effect. However, the error message in the modal is garbled most likely due to the inclusion of a link.

This is what the modal looks like currently:

Untitled

This is the message string that it derives from:

<message name="IDS_BRAVE_REWARDS_LOCAL_REDIRECT_MODAL_NOT_ALLOWED" desc="">BAT is not currently supported in your region. Please refer <ph name="BEGIN_LINK">$1</ph>here<ph name="END_LINK">$2</ph> for updates.</message>

So the message text should say BAT is not currently supported... instead of just here.

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 6, 2021

I think this may be resolved with your recent changes, @szilardszaloki? If so, feel free to close this issue.

@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 6, 2021
@szilardszaloki
Copy link
Contributor

That's right. And actually, #16650 is a duplicate. I'll tag and close both with #16652 's PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants