Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in CNAME uncloaking #14756

Closed
antonok-edm opened this issue Mar 16, 2021 · 4 comments · Fixed by brave/brave-core#8262
Closed

Fix regression in CNAME uncloaking #14756

antonok-edm opened this issue Mar 16, 2021 · 4 comments · Fixed by brave/brave-core#8262

Comments

@antonok-edm
Copy link
Collaborator

antonok-edm commented Mar 16, 2021

This change accidentally modified a URL involved in CNAME uncloaking, causing uncloaked results to be ignored.

There may be some additional platform-specific issues with the DNS resolvers that prevent this change from working, but those are captured in #14755.

@kjozwiak
Copy link
Member

This only fixes Android & macOS as per the labels. Win x64 & Linux are still displaying 1 after adding the custom filter in brave://adblock and will be addressed in a follow up issue.

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 17, 2021
@stephendonner
Copy link

Verified PASSED using the testplan from brave/brave-core#8262 on build

Brave 1.23.43 Chromium: 89.0.4389.90 (Official Build) beta (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

Steps:

  1. visited https://pushbullet.com (there should be 1 request being blocked)

Screen Shot 2021-03-17 at 1 29 43 PM

  1. added the following custom filer via brave://adblock
||stripecdn.map.fastly.net^$important
||d2rhbqunra2aep.cloudfront.net^$important

Screen Shot 2021-03-17 at 1 27 47 PM

  1. opened new tab
  2. visited https://pushbullet.com (there should be 2 requests blocked)

Screen Shot 2021-03-17 at 1 27 38 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 17, 2021
@kjozwiak
Copy link
Member

Also verified on Win x64 on Nightly via brave/brave-core#8262 (comment). The remaining part of this will be fixed via brave/brave-core#8279 which will also be uplifted.

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.22.66 x64 build

Before custom filters Custom Filters Post custom filters
image image image

Verification passed on Samsung Tab A with Android 10 running 1.22.66 x64 build

Before custom filters Custom Filters Post custom filters
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants