Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards panel doesn't list IPFS links fully in panel #14841

Closed
srirambv opened this issue Mar 19, 2021 · 3 comments · Fixed by brave/brave-core#8463
Closed

Rewards panel doesn't list IPFS links fully in panel #14841

srirambv opened this issue Mar 19, 2021 · 3 comments · Fixed by brave/brave-core#8463

Comments

@srirambv
Copy link
Contributor

Description

Rewards panel doens't list IPFS links fully in panel

Steps to Reproduce

  1. Enable Rewards
  2. Use public gateway for IPFS and visit any IPFS link
  3. Open rewards panel, site name isn't shown fully

Actual result:

image

Expected result:

Should show the page name correclty

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.21.77 Chromium: 89.0.4389.90 (Official Build) (64-bit)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @bbondy

@stephendonner stephendonner changed the title Rewards panel doens't list IPFS links fully in panel Rewards panel doesn't list IPFS links fully in panel Mar 19, 2021
@emerick
Copy link
Contributor

emerick commented Mar 23, 2021

I think this goes beyond a display problem. I'm not positive how we want to handle this long-term, but since the current publisher architecture is domain-focused I would suggest for now that we not show anything in the Rewards panel for IPFS links.

cc: @bbondy

@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 24, 2021
@bbondy
Copy link
Member

bbondy commented Apr 6, 2021

Let's go with what @emerick suggested for now please @spylogsster.

So for anything that is IPFS we'd just show this like it does for chrome/brave/about pages:
Screen Shot 2021-04-06 at 3 13 02 PM

@stephendonner
Copy link

Verified FIXED using nightly build

Brave 1.25.11 Chromium: 90.0.4430.61 (Official Build) nightly (x86_64)
Revision dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS macOS Version 11.2.3 (Build 20D91)

Loaded the following:

  • ipfs:QmYwAPJzv5CZsnA625s3Xf2nemtYgPpHdWEz79ojWnPbdG/readme
  • ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  • ipfs://QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/Tokyo_National_Museum.html
  • ipns://brantly.eth
  • https://wikipedia-on-ipfs.org

Confirmed the tip UI only shows up for the https://wikipedia-on-ipfs.org page; not for any of the ipfs:// / ipns:// links.

example example example example example
Screen Shot 2021-04-12 at 4 28 21 PM Screen Shot 2021-04-12 at 4 26 17 PM Screen Shot 2021-04-12 at 4 25 52 PM Screen Shot 2021-04-12 at 4 24 28 PM Screen Shot 2021-04-12 at 4 26 34 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants