Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private tab info has Tor in lowercase #1486

Closed
srirambv opened this issue Oct 10, 2018 · 4 comments
Closed

Private tab info has Tor in lowercase #1486

srirambv opened this issue Oct 10, 2018 · 4 comments
Assignees
Labels

Comments

@srirambv
Copy link
Contributor

Description

Private tab info has Tor in lowercase

Steps to Reproduce

  1. Open a private tab in 0.55.12
  2. Tor is in lowercase (see screenshot below)

Actual result:

image

Expected result:

Should be similar to b-l
image

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes on both Dev and Beta
  • Does it reproduce on browser-laptop? No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv srirambv added needs-text-change This change requires some careful wording. feature/private-browsing QA/Yes labels Oct 10, 2018
@srirambv srirambv added this to the Releasable builds 0.55.x milestone Oct 10, 2018
@srirambv
Copy link
Contributor Author

@btlechowski what about in Private tab?

@btlechowski
Copy link

Reproduced on Windows 7. Also visible in guest window.

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

image

@tildelowengrimm
Copy link
Contributor

The current new tab pages for these windows are placeholders which we're replacing with whole new designs.

@tildelowengrimm tildelowengrimm modified the milestones: Releasable builds 0.55.x, Dupe / Invalid / Not actionable Oct 11, 2018
@tildelowengrimm
Copy link
Contributor

#1507

@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed needs-text-change This change requires some careful wording. closed/duplicate Issue has already been reported feature/private-browsing labels Oct 22, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants