Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to resolve Unstoppable Domains dropdown items are not translated in other locales #14862

Closed
GeetaSarvadnya opened this issue Mar 22, 2021 · 4 comments · Fixed by brave/brave-core#8317

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 22, 2021

Description

Method to resolve Unstoppable Domains dropdown items are not translated in other locales

Steps to Reproduce

  1. Set OS locale to France or any other locale
  2. Open brave 1.22.66
  3. Open brave://settings/extensions
  4. Method to resolve Unstoppable Domains dropdown items are not translated in other locales

Actual result:

image

Expected result:

Dropdown items should be translated

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.22.66 Chromium: 89.0.4389.90 (Build officiel) (64 bits)
Révision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
Système d'exploitation Windows 10 OS Version 2004 (Build 19041.867)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @mkarolin

@mkarolin
Copy link
Contributor

cc: @yrliou

@LaurenWags
Copy link
Member

LaurenWags commented Mar 22, 2021

Reproduces on Nightly (using Spanish) as well


Brave | 1.24.10 Chromium: 89.0.4389.90 (Build oficial) nightly (x86_64)
-- | --
Revisión | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
Sistema operativo | macOS Versión 10.15.7 (Compilación 19H524)

Captura de pantalla 2021-03-22 a las 9 44 14 a  m

@kjozwiak
Copy link
Member

Added QA/Blocked as we'll need to wait for the translations to get merged into 1.23.x. @mkarolin please keep us updated re: merging translations into 1.23.x and unblocking the above 👍

@stephendonner
Copy link

Removing QA/Blocked label as we now have the 1.23.70 build.

Verified PASSED using

Brave 1.23.70 Chromium: 90.0.4430.70 (Official Build) (x86_64)
Revision 3954de7175366f3b7edca576f140dfa273e6b5ae-refs/branch-heads/4430@{#1210}
OS macOS Version 11.2.3 (Build 20D91)

Confirmed using the inline steps to reproduce that the dropdown items are now correctly translated in both French and Spanish.

French Spanish
Capture d’écran 2021-04-13 à 15 00 41 Captura de pantalla 2021-04-13 a las 15 03 08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment