-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tipping UI should be able to handle values with or without decimal points #15050
Comments
Verified passed with
Per discussion with @Miyayes, QA is only testing this with the default banners and not creator selected tip amounts from the creators website. Test plan from brave/brave-core#8404 was verified (only default tip banners as per note above). Confirmed fractional tips go thru with both anon (VG BAT) and Uphold KYC wallets. One-time tip with fractional default tipping amount - Anon WalletConfirmed UI showed fractional tipping amounts correctly
Logs
One-time tip with fractional default tipping amount - Uphold WalletConfirmed UI showed fractional tipping amounts correctly
Logs - 95%
Logs - 5%
Monthly tip with fractional default tipping amount - Anon WalletConfirmed UI showed fractional tipping amounts correctly
Logs
Monthly tip with fractional default tipping amount - Uphold WalletConfirmed UI showed fractional tipping amounts correctly
Logs for 95%:
Logs for 5%:
Verification passed on
Verified the above test plan One-time tip with fractional default tipping amount - Anon Wallet
Monthly tip with fractional default tipping amount - Anon Wallet
Logs
One-time tip with fractional default tipping amount - Uphold Wallet
Logs 95% contribution
logs 5% contribution
Monthly tip with fractional default tipping amount - Uphold Wallet
Logs 95% contribution
logs 5% contribution
Verification passed on
One-time tip with fractional default tipping amount - Anon WalletConfirmed UI showed fractional tipping amounts correctly
One-time tip with fractional default tipping amount - Uphold WalletConfirmed UI showed fractional tipping amounts correctly
Logs for 95% contribution
Logs for 5% contribution
Monthly tip with fractional default tipping amount - Anon WalletConfirmed UI showed fractional tipping amounts correctly
Monthly tip with fractional default tipping amount - Uphold WalletConfirmed UI showed fractional tipping amounts correctly
Logs for 95% contribution
Logs for 5% contribution
|
Per discussion with @deeppandya, fractional-tipping UI isn't yet available on Android; filed #15618 and am removing |
Description
Default tipping amounts can be changed asynchronously server-side, and then are fetched by the client (browser). Currently, the tipping amounts defined in the JSON response from the server endpoint uses whole numbers like:
1, 5, 10
with no decimal points. However, we want to be able to use numbers like0.25
with decimal points as well.The client should be able to handle both cases: whole numbers
1
without decimal points, and numbers with decimals such as1.75
, or1.00
.Solution
Ensure that the tipping UI and banner expects and can handle non-integer values.
The text was updated successfully, but these errors were encountered: