-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notifications to imports #15176
Comments
I wrote some details about import failing on some websites in ipfs/ipfs-companion#227 (mostly Firefox, but I feel a variant applies here too). TLDR: In IPFS Companion it fails due to tracking protection (either regular CORS and other headers set by website, or browser itself behaving more strict for some reason, like in Firefox with protection enabled). We can't do much in a browser extension, but Brave should be able to side-steps those protections if the request was triggered by user interaction with native Import UI. |
Verified
Steps: (YouTube video) - import failure
(MP4 video) - import success
(HTML page) - import partly complete
|
@spylogsster @lidel do either of you happen to have a handy use-case for |
@stephendonner try to import same link twice, next imports will be partially completed because same link already exists in target directory |
Description
Created from @bbondy comment brave/brave-core#8422 (comment)
Right clicking on a YouTube video (you need to right click twice because youtube tries to override the context menu), allows you to select import Video. But then it gives an error.
IPFS Companion also gives an error.
The error seems OK, but the way we deal with the error is that we don't do anything. IPFS companion does a notification like this for the error. We could do something similar unless you have a better suggestion.
Actual result:
Expected result:
Reproduces how often:
easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: