Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS interstitial page content and button gets clipped when the Developer Tools panel is open #15375

Closed
stephendonner opened this issue Apr 19, 2021 · 2 comments · Fixed by brave/brave-core#8732

Comments

@stephendonner
Copy link

stephendonner commented Apr 19, 2021

Description

IPFS interstitial page content gets clipped when the Developer Tools panel is open

Steps to Reproduce

  1. new profile
  2. open the Developer Tools
  3. load ipfs://en.wikipedia-on-ipfs.org
  4. look at the text and button below the orange Use a local node button

Actual result:

Screen Shot 2021-04-19 at 4 05 32 PM

Expected result:

The page should scroll instead of having content cut off.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (x86_64)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

/cc:ing @karenkliu in case she has suggestions

@karenkliu
Copy link

The page should scroll if viewport height is smaller than the content height.

@stephendonner
Copy link
Author

Verified FIXED using

Brave 1.26.18 Chromium: 91.0.4472.38 (Official Build) nightly (x86_64)
Revision 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS macOS Version 11.3.1 (Build 20E241)

Confirmed that resizing and constraining the window size with/without the Developer Tools panel, doesn't result in the splitting/clipping of the content, as before.

Screen Shot 2021-05-12 at 11 45 11 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants