Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove whitespace at the end of the version string printed by Brave in the release channel #15414

Open
wknapik opened this issue Apr 21, 2021 · 2 comments

Comments

@wknapik
Copy link
Contributor

wknapik commented Apr 21, 2021

Description

$ brave --version|sed 's/$/$/g'
Brave Browser 90.1.23.71 $
$

That space at the end can mess up version comparisons in scripts.

Steps to Reproduce

  1. Call brave --version

Actual result:

Version with space at the end.

Expected result:

Version without space at the end.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave 1.23.71 Chromium: 90.0.4430.72 (Official Build) (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? ?

Miscellaneous Information:

This does not affect other channels, because they append another word after the problematic space.

@wknapik
Copy link
Contributor Author

wknapik commented Apr 25, 2023

Still an issue

% brave --version|sed 's/$/$/g'        
Brave Browser 112.1.50.125 $
%

@fmarier
Copy link
Member

fmarier commented Aug 1, 2023

Only in the case of the release channel:

$ brave-browser-stable --version|sed 's/$/$/g'
Brave Browser 115.1.56.14 $
$ brave-browser --version|sed 's/$/$/g'
Brave Browser 115.1.57.33 beta$
$ brave-browser-nightly --version|sed 's/$/$/g'
Brave Browser 116.1.58.57 nightly$

This is upstream behavior:

$ google-chrome-stable --version|sed 's/$/$/g'
Google Chrome 115.0.5790.110 $

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants