Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Follow up to #15394] Add setting for tab groups #15453

Closed
srirambv opened this issue Apr 22, 2021 · 2 comments · Fixed by brave/brave-core#8614
Closed

[Follow up to #15394] Add setting for tab groups #15453

srirambv opened this issue Apr 22, 2021 · 2 comments · Fixed by brave/brave-core#8614
Assignees
@samartnik
Labels
feature/settings OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/include
Milestone
1.23.x - Release #3

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 22, 2021 •
edited
Loading

Description

Slack: https://bravesoftware.slack.com/archives/DCLU7012P/p1618935977006400

In Settings->Appearance please add a setting to enable/disable Tab Groups

Title
Enable Tab Groups

Default = On

Test Plan

  • Verify enable/disable tab group triggers restart
  • Verify enabling tab group shows context menu option to group tabs
  • Verify disabling tab group doesn't show context menu option to group tabs
  • Verify disabling tab group disables tab grouping in tab tray
@srirambv srirambv added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Apr 22, 2021
@srirambv srirambv added this to the 1.23.x - Release #2 milestone Apr 22, 2021
@srirambv srirambv added feature/settings priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 22, 2021
@srirambv srirambv removed this from the 1.23.x - Release #2 milestone Apr 22, 2021
@samartnik samartnik self-assigned this Apr 22, 2021
@kjozwiak kjozwiak added this to the 1.23.x - Release #3 milestone Apr 22, 2021
@kjozwiak kjozwiak mentioned this issue Apr 22, 2021
Closed
@samartnik samartnik mentioned this issue Apr 22, 2021
Merged
24 tasks
This was referenced Apr 22, 2021
Merged
Merged
@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.23.74 x64 build

  • Verified enable/disable tab group triggers restart
  • Verified enabling tab group shows context menu option to group tabs
  • Verified disabling tab group doesn't show context menu option to group tabs
  • Verified disabling tab group disables tab grouping in tab tray
  • Verified tab grouping works with normal / private tabs
Android.ARM.tab.group.mp4

Verification passed on Samsung Tab A with Android 10 running 1.23.74 x64 build

  • Verified Tablet doesn't have a tab group settings
Android.Tab.group.setting.MP4

@kjozwiak kjozwiak mentioned this issue Apr 23, 2021
Closed
@bw4518
Copy link

bw4518 commented Jun 28, 2021 •
edited
Loading

Verify disabling tab group doesn't show context menu option to group tabs

In my case, only re-enabling (relaunch) and re-disabling (relaunch) "Tab Groups" made context menu option go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
feature/settings OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/include
Projects
None yet
Milestone
1.23.x - Release #3
Development

Successfully merging a pull request may close this issue.

[Android] Fixes for Tab Groups option brave/brave-core
4 participants
@bw4518 @kjozwiak @srirambv @samartnik