-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to add IPFS peer servers #15567
Comments
When it comes to UX, you may have the best luck with a single input that takes a string and extracts Usually, user will just copy a single address in form of (could be any of those):
To keep things simple:
This is enough because even if none of |
for compatibility reasons decided to add 1 as a valid prefix if it is preceded with /p2p/ in order to validate PeerIDs like |
@spylogsster mind adding a step-by-step testplan with instructions for a two-machine setup (running the same build, I presume) with the 2nd machine's ports changed appropriately, to test? I tried to get this working by changing the port via the |
@stephendonner added steps, please disable "Method to resolve Unstoppable Domains" and "Method to resolve Ethereum Name Service (ENS)" and "Redirect IPFS resources to the configured IPFS gateway" options in settings, while https://github.com/brave/brave-core/pull/9031/files is not merged, then node status page will be loaded successfully |
Verified
Pre-requisite (to make it easier): Steps (do 1-4 on both
|
Allow users to enter the peers to the config
https://github.com/ipfs/go-ipfs/blob/master/docs/config.md#peering
##Test Plan
The text was updated successfully, but these errors were encountered: