Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning on Redirect IPFS resources to the configured IPFS gateway breaks ipfs status page #16112

Closed
Tracked by #17112
youssef20031 opened this issue May 27, 2021 · 1 comment · Fixed by brave/brave-core#9031

Comments

@youssef20031
Copy link

Description

When I turn on Redirect IPFS resources to the configured IPFS gateway, it breaks IPFS status page. This is due to brave redirecting the status page through IPFS and it does not detect the IPFS client running

Steps to Reproduce

  1. Install ipfs
  2. turn on Redirect IPFS resources to the configured IPFS gateway
  3. test the status page

Actual result:

Screenshot 2021-05-27 212422

Expected result:

Screenshot 2021-05-27 212455

Reproduces how often:

Every time

Brave version (brave://version info)

Brave 1.25.68 Chromium: 91.0.4472.77 (Official Build) (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Windows 10 OS Version 2103 (Build 19043.1023)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Yes
  • Can you reproduce this issue with the beta channel?
  • N/A
  • Can you reproduce this issue with the nightly channel?
  • N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • No
  • Does the issue resolve itself when disabling Brave Rewards?
  • No
  • Is the issue reproducible on the latest version of Chrome?
  • No

Miscellaneous Information:

  • It is preferable to install the IPFS extension and on a quick note it identified the OS version wrong; it was 2009 while it should have been 2103 or 21H1
@stephendonner
Copy link

stephendonner commented Jun 9, 2021

Verified FIXED using the testplan from brave/brave-core#9031 with

Brave 1.27.51 Chromium: 91.0.4472.88 (Official Build) nightly (x86_64)
Revision 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. visited brave://ipfs-internals
  4. clicked Install and launch
  5. via brave://settings/ipfs set Redirect IPFS resources to the configured IPFS gateway via the toggle to On
  6. clicked on My Node from brave://ipfs-internals
  7. was taken to http://127.0.0.1:45002/ipfs/bafybeianwe4vy7sprht5sm3hshvxjeqhwcmvbzq73u55sdhqngmohkjgs4/#/ which I confirmed worked (updated peers list, connected state, etc.)
pref IPFS status page
Screen Shot 2021-06-09 at 10 16 57 AM Screen Shot 2021-06-09 at 10 17 03 AM

Verification passed on


Brave | 1.27.78 Chromium: 91.0.4472.114 (Official Build) beta (64-bit)
-- | --
Revision | 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS | Windows 10 OS Version 2004 (Build 19041.1052)

pref IPFS status page
image image

Verified FIXED using the testplan from brave/brave-core#9031 with

Brave 1.27.87 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Linux

Steps:

  1. new profile
  2. launched Brave
  3. visited brave://ipfs-internals
  4. clicked Install and launch
  5. via brave://settings/ipfs set Redirect IPFS resources to the configured IPFS gateway via the toggle to On
  6. clicked on My Node from brave://ipfs-internals
  7. was taken to http://127.0.0.1:45002/ipfs/bafybeianwe4vy7sprht5sm3hshvxjeqhwcmvbzq73u55sdhqngmohkjgs4/#/ which I confirmed worked (updated peers list, connected state, etc.)
pref IPFS status page
Screen Shot 2021-07-02 at 1 31 38 PM Screen Shot 2021-07-02 at 1 31 52 PM

|

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment