Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Brave Talk tooltip for togetherPageTitle on the new-tab page #16288

Closed
stephendonner opened this issue Jun 9, 2021 · 2 comments
Closed
Assignees
Labels

Comments

@stephendonner
Copy link

Description

Provide a Brave Talk tooltip for togetherPageTitle on the new-tab page

Steps to Reproduce

  1. new profile
  2. launch Brave nightly
  3. open a new-tab page
  4. on the bottom, hover over the video-camera icon
  5. look at the resulting tooltip

Actual result:

Screen Shot 2021-06-08 at 5 30 46 PM

This also shows up as an error in the console:

[33320:259:0607/113806.078262:ERROR:CONSOLE(219)] "Unexpected condition on chrome://newtab/: Could not find value for togetherPageTitle", source: chrome://resources/js/load_time_data.js (219)

Expected result:

Should (now) say Call with Brave Talk or something similar, since we've renamed from Brave Together

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.48 Chromium: 91.0.4472.88 (Official Build) nightly (x86_64)
Revision 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS macOS Version 11.4 (Build 20F71)

/cc @petemill @mrose17 @mattmcalister @karenkliu

@srirambv
Copy link
Contributor

srirambv commented Jun 9, 2021

@stephendonner stephendonner added the closed/duplicate Issue has already been reported label Jun 9, 2021
@stephendonner
Copy link
Author

This is a duplicate of @GeetaSarvadnya's bug - sorry for not finding it earlier!

#13513

@petemill petemill self-assigned this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants