Show background images switch does not disable NTP-SI pref

[moritzhaller]

Description

Show background images switch does not disable NTP-SI pref. It does move the NTP-SI switch to the left, however the color still indicates active (orange) and the pref stays enabeld.

Steps to Reproduce

1. Disable "show background images" switch on NTP customise widget

Actual result:

only background images, but not NTP-SI are disabled

Expected result:

both prefs are disabled

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[diracdeltas]

cc @mattmcalister @jsecretan - this should be fixed sooner than later since the user expects NTP SI to be disabled when the UI is in this state.

[moritzhaller]

cc @mattmcalister @jsecretan - this should be fixed sooner than later since the user expects NTP SI to be disabled when the UI is in this state.

just to clarify @diracdeltas - the user won't see any sponsored images with this bug. And the bug only appear when disabling the "parent switch". When disabling the "child switch" directly, all works as expected. However we still need this to be fixed as we rely on the NTP-SI pref to decide if we want to start up the ads process.

[tmancey]

@moritzhaller As discussed this is no longer the case, so this issue is no longer a priority for Brave News ads

[rebron]

Closing as stale. Resolved when we added ability to choose a background image.