Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Talk/Together promo tooltip on NTP shouldn't be shown until 3 days after fresh install #16312

Closed
stephendonner opened this issue Jun 9, 2021 · 3 comments · Fixed by brave/brave-core#9616
Assignees
Labels
bug feature/new-tab onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop premium All issues related to Brave Premium QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

Description

Brave Talk/Together promo tooltip on NTP shouldn't be shown until 3 days after fresh install

Steps to Reproduce

  1. new profile
  2. launch Brave nightly
  3. open a new-tab page
  4. look at the bottom-right corner

Actual result:

The Brave Together (soon to be Brave Talk: #16289) promo tooltip is displayed.

Screen Shot 2021-06-09 at 9 51 14 AM

Expected result:

Per the design spec (https://www.figma.com/file/ycXqw8euy6z41uXrlDni6K/Desktop-Brave-Talk?node-id=1091%3A30916), for fresh installs, it should only be shown 3 days after installation:

Attention will also be drawn to the icon with a promo tooltip that points to it. The promo tooltip shows to:
Existing users - as soon as the user updates Brave to a supported version. If the user does not interact with it, it shows on the new tab page for a total view time of 4 seconds spread across new tab pages.
New users - 3 days after install. If the user does not interact with it, it shows on the new tab page for a total view time of 4 seconds spread across new tab pages.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.50 Chromium: 91.0.4472.88 (Official Build) nightly (x86_64)
Revision 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS macOS Version 11.4 (Build 20F71)

/cc @karenkliu @rebron @mattmcalister

@kjozwiak
Copy link
Member

kjozwiak commented Aug 9, 2021

Adding QA/Blocked until we get Brave Talk enabled on main (staging) via Griffin. After it's enabled on staging, QA will be able to run through the above verification. Once we get closer to Brave Talk release date, we'll push the same change into production.

@kjozwiak
Copy link
Member

kjozwiak commented Aug 9, 2021

Removing QA/Blocked as brave/brave-variations#93 was merged into main (Griffin staging).

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 10, 2021

Verification passed on


Brave | 1.28.105 Chromium: 92.0.4515.131 (Official Build) (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1110)

  • Verified the STR from the description

New User(Clean profile)

now after 3 days
image image

Existing User(Upgraded profile)

Brave Talk promo tooltip isn't shown for the existing user after the upgrade to 1.28.x - Logged #17420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/new-tab onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop premium All issues related to Brave Premium QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants