Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing period in Tor/.onion Settings description #16326

Closed
stephendonner opened this issue Jun 9, 2021 · 8 comments · Fixed by brave/brave-core#9132
Closed

Missing period in Tor/.onion Settings description #16326

stephendonner opened this issue Jun 9, 2021 · 8 comments · Fixed by brave/brave-core#9132

Comments

@stephendonner
Copy link

Description

Missing period in Tor/.onion Settings description

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load brave://settings/extensions
  4. look at the Automatically redirect .onion sites section

Actual result:

Screen Shot 2021-06-09 at 3 45 50 PM

Expected result:

Should have a period at the end of the descriptive sentence; additionally, the copy itself seems a bit stilted.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.26.54 Chromium: 91.0.4472.88 (Official Build) beta (x86_64)
Revision 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS macOS Version 11.4 (Build 20F71)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes
@stephendonner stephendonner added good first issue OS/Desktop needs-text-change This change requires some careful wording. bug labels Jun 9, 2021
@srl23
Copy link

srl23 commented Jun 10, 2021

Would I be able to work on this task?

@stephendonner
Copy link
Author

Would I be able to work on this task?

Yes, absolutely; please take a look through the code at https://github.com/brave/brave-core, find the relevant string(s) and submit a PR! Assigning to you; please unassign if you change your mind :-)

@tonycoldashian
Copy link

I would like to work on this if that's okay.

@bsclifton
Copy link
Member

@tonycoldashian anything open is fair game for submitting a PR. @srl23 were you able to make progress?

@srl23
Copy link

srl23 commented Jun 14, 2021

@bsclifton Sorry to say I haven't. I've been running into technical problems that I've been unable to resolve. I'm willing to let @terrycoldashian have the issue if they'd like it and I'll take a different one, as soon as things are fixed on my end.

@tonycoldashian
Copy link

Hey @bsclifton , I opened a PR with my contribution. It's my first time on open source, sorry if something is not right.

@bsclifton
Copy link
Member

@tonycoldashian comment left in PR 😄

@stephendonner
Copy link
Author

Verified FIXED using

Brave 1.28.3 Chromium: 91.0.4472.106 (Official Build) nightly (x86_64)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS macOS Version 11.4 (Build 20F71)

Screen Shot 2021-06-17 at 3 00 27 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants