-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing period in Tor/.onion Settings description #16326
Comments
Would I be able to work on this task? |
Yes, absolutely; please take a look through the code at https://github.com/brave/brave-core, find the relevant string(s) and submit a PR! Assigning to you; please unassign if you change your mind :-) |
I would like to work on this if that's okay. |
@tonycoldashian anything open is fair game for submitting a PR. @srl23 were you able to make progress? |
@bsclifton Sorry to say I haven't. I've been running into technical problems that I've been unable to resolve. I'm willing to let @terrycoldashian have the issue if they'd like it and I'll take a different one, as soon as things are fixed on my end. |
Hey @bsclifton , I opened a PR with my contribution. It's my first time on open source, sorry if something is not right. |
@tonycoldashian comment left in PR 😄 |
Verified
|
Description
Missing period in Tor/.onion Settings description
Steps to Reproduce
brave://settings/extensions
Automatically redirect .onion sites
sectionActual result:
Expected result:
Should have a period at the end of the descriptive sentence; additionally, the copy itself seems a bit stilted.
Reproduces how often:
100%
Brave version (brave://version info)
Version/Channel Information:
The text was updated successfully, but these errors were encountered: