Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks not showing only in new tab #16535

Closed
dnrm opened this issue Jun 21, 2021 · 4 comments
Closed

Bookmarks not showing only in new tab #16535

dnrm opened this issue Jun 21, 2021 · 4 comments

Comments

@dnrm
Copy link

dnrm commented Jun 21, 2021

Description

Always show bookmarks in new tab toggle doesn't work.

Steps to Reproduce

  1. Go to settings
  2. Disable bookmarks but click the "Always show bookmarks on new tab page" toggle.
  3. Open a new tab

Actual result:

Bookmarks aren't shown

Expected result:

Bookmarks to be shown only in new tab

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave: 1.25.73 Chromium: 91.0.4472.106 (Official Build) (x86_64)
Revision: 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS: macOS Version 10.15.7 (Build 19H1030)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes

  • Can you reproduce this issue with the beta channel?
    Don't know (haven't tested)

  • Can you reproduce this issue with the nightly channel?
    Don't know (haven't tested)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Does the issue resolve itself when disabling Brave Rewards?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No

Miscellaneous Information:

None

@rebron
Copy link
Collaborator

rebron commented Jun 21, 2021

@stephendonner When you get a chance, can you take a look? I can't reproduce this myself as I'm seeing bookmarks on the new tab page but not on any other tab when selecting "Always show bookmarks on a new tab page".

@dnrm Do you have any bookmark related extensions or other extension that may be conflicting here?

@rebron rebron added needs-investigation A bug not 100% confirmed/fixed feature/bookmarks labels Jun 21, 2021
@dnrm
Copy link
Author

dnrm commented Jun 22, 2021

I found out that the daily.dev extension causes this issue. Thanks @stephendonner

@rebron
Copy link
Collaborator

rebron commented Jun 22, 2021

@dnrm Thanks for following up. I'm going to close this one out then.

@rebron rebron closed this as completed Jun 22, 2021
@rebron rebron added closed/not-actionable and removed needs-investigation A bug not 100% confirmed/fixed labels Jun 22, 2021
@stephendonner
Copy link

Sorry for missing the ping; thanks for resolving @dnrm and @rebron 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants