Rewards: unable to exclude sites from auto-contribute

[nomaed]

Description

chrome://rewards provides a list of auto-contribute sites. Next to each of them there is an 'X' with the tooltip to remove the site from auto-contributions. However, when clicking on the X, nothing happens.

The same is true for the modal dialog that opens when clicking on "See all N sites" under the list.

(I wasn't able to find any issues about the auto-contribute or exclusion in github issues and in the community forums, but if I'm just bad at searching, please close this issue with a link to wherever is relevant)

Steps to Reproduce

1. Open Rewards Settings (or navigate directly to chrome://rewards/)
2. Enable Auto-Contribute
3. Click on 'X' on one of the listed websites

Actual result:

The list remains the same, the site is not removed

Expected result:

The site is removed from auto-contributions list and is excluded from the feature

Reproduces how often:

Every time

Brave version (brave://version info)

• Brave: 0.56.4 Chromium: 70.0.3538.54 (Official Build) dev (64-bit)
• Revision: 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{Allow user to turn off web notifications globally in Setting #937}
• OS: Mac OS X 10.13.6
• JavaScript: V8 7.0.276.27

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
• Does it reproduce on browser-laptop?

Additional Information

Repro video:

[NejcZdovc]

@kjozwiak can you please test it

[rebron]

I can't reproduce this issue with current builds on all three channels. Removed several sites from auto contribute list on each version.

Dev build:
Version 0.57.2 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Beta build:
Version 0.56.6 Chromium: 70.0.3538.67 (Official Build) beta (64-bit)
Release build:
Version 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)

@nomaed is this still an issue with the current dev version - Version 0.57.2 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)

[nomaed]

@rebron That's the version I'm running, on which I saw this. Pretty sure it happened on earlier versions too. However, I just opened the setting screen and the list of sites is empty for some reason. I'll wait for it to fill up and try again.

I will also try after disabling all extensions, in case this is a conflict with one of them, and will update the issue with my findings.

[nomaed]

Upgraded to 0.57.3, also tried with --disable-extensions but this didn't help.
However, I created a new clean profile and there I was able to remove an item.

Is there any good way to compare 2 profiles? Not sure how the data is saved but if it's JSON or XML, maybe I can diff the two?

Update: I just noticed (after restarting in normal mode) that I could remove one site from the list normally, but others are not being removed. I thought maybe that I couldn't remove "github" becuase it was open in another tab, but this is also true about other sites that are not open, so I am not sure what's going on. If there are any suggestions, or if there's some data I can give you to help diagnosing it, please let me know.

Update 2: I'm building brave-browser from sources right now so I can have the JS files in non-minified version, I'll try debugging what's going on.

[nomaed]

I added a screen recording of this behavior:
https://user-images.githubusercontent.com/9551921/47708567-03364380-dc37-11e8-80be-60e0a9d715cc.gif

Some items are removed, some aren't.

[NejcZdovc]

@nomaed thank you for the recording, this is helpful, we will try to reproduce it and fix it

[da2x]

I've got the same issue on two of my three computers.

Also, clicking Show All Sites and clicking Restore All also restores a random number of sites. Clicking it multiple times changes the counter but it never reaches 0. I can now block some sites that was blocked before but not all.

I'll bet issue #1873 is another symptom of the same core issue.

[NejcZdovc]

@brave/legacy_qa where you able to reproduce this one?

[LaurenWags]

Verified passed with

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Mac OS X

• I had a profile from 0.58.18 which reproduced the issue:
  

• When I updated to 0.58.20, I was able to exclude sites:
  

Verification passed on

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Linux

• Sites can be excluded via the ac list by clicking on the x button

Verification passed on

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Windows 10

• Able to exclude the sites by clicking on x button
  

[eddymul]

I'm still experiencing this in
Version 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Distributor ID: Ubuntu
Description: Ubuntu 18.04.1 LTS
Release: 18.04
Codename: bionic
Linux 4.18.0-13-generic #14~18.04.1-Ubuntu SMP Thu Dec 6 14:09:52 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

[t0m3kf]

Yes, I can't exclude sites on the same build
Version 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Windows 7 64bit

[scmart]

@jonathansampson Still not working on Version 0.58.21 Chromium: 71.0.3578.98 (Ubuntu 16.04)

Having the dev console open, I'm seeing no errors or warnings when attempting to remove sites. Less than half of sites are actually removed when attempting to remove them, and "restore all" does not allow sites to be removed this time (I also permanently have 4 sites still removed after "restore all".

Also, some sites are listed twice in the list. For example, spots 1 and 2 are both reddit. Neither of them can be removed.

[Miyayes]

Fixed for some users, but still many reports that it has not fixed it for all users. (About 3-5 reports in community since updating to 0.58.21.) @NejcZdovc

[kjozwiak]

@NejcZdovc did mention that this won't fix all the cases that users have been experiencing. Created #2943 to follow the cases that haven't been fixed by this issue and brave/brave-core#1239.

As this one fixed one particular case, we're not going to re-open this as it already landed in 0.58.21. Lets add all new information under #2943.