Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user that a browser restart is required for in-line tipping toggle to take effect #16941

Closed
Miyayes opened this issue Jul 14, 2021 · 2 comments · Fixed by brave/brave-core#9582

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 14, 2021

Description

When toggling in-line tipping buttons, user needs to restart the browser in order for this to take effect.

Currently, there is no notice or banner telling the user that a browser restart is required, leading to confusion.

Solution

Whenever inline (content-level) tipping checkboxes are toggled in brave://rewards (settings page), put a banner at the top or bottom (can be existing Chromium object if easier) telling the user a browser restart is required for changes to take effect.

(Maybe compare the banner that shows up at bottom in brave://flags when things are toggled.)

Notes

Related: #5551

@Miyayes Miyayes added feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. OS/Desktop labels Jul 14, 2021
@emerick
Copy link
Contributor

emerick commented Jul 28, 2021

@Miyayes I show a small Relaunch button in the tips settings box when any inline tip option is toggled. This mimics how Chrome handles settings changes that require a browser restart (for example, when changing the default UI language in brave://settings). Let me know what you think!

127354488-6ed8a5ea-9317-4742-b5f3-e39edf66e117

@stephendonner
Copy link

stephendonner commented Aug 2, 2021

Verified PASSED using the testplan from brave/brave-core#9582 with

Brave 1.29.45 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS macOS Version 12.0 (Build 21A5294g)

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://rewards
  4. clicked on the Tip Settings icon
  5. toggled Reddit to off (deselected)
  6. confirmed the Relaunch button appeared beneath the list of sites in Tip Settings
  7. confirmed clicking Relaunch restarted the browser and restored current tabs
  8. visited reddit.com/u/alex_the_brave verified it doesn't show tip buttons per new setting
  9. toggled Twitter to off (deselected)
  10. confirmed clicking on the Relaunch button restarted the browser
  11. visited twitter.com/bravelaurenwags and confirmed no in-line tipping buttons
  12. restored both Reddit and Twitter prefs back to on (selected)
  13. confirmed their respective inline tipping buttons appears and worked (brought up appropriate tipping banner)
relaunch reddit - disabled reddit - enabled twitter - disabled twitter - enabled github - disabled github - enabled
Screen Shot 2021-08-02 at 3 46 03 PM Screen Shot 2021-08-02 at 3 46 56 PM Screen Shot 2021-08-02 at 4 03 53 PM Screen Shot 2021-08-02 at 3 59 44 PM Screen Shot 2021-08-02 at 4 00 31 PM Screen Shot 2021-08-02 at 4 11 47 PM Screen Shot 2021-08-02 at 4 11 10 PM

Verification passed on


Brave | 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Reddit disabled Relaunch Twitter disabled Relaunch Github disabled Relaunch
image image image image image image

Verification passed on

Brave 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS Ubuntu 18.04 LTS

Reddit
image
image

Twitter
image
image

Github
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment