Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move iOS recovery code option to Backup & Restore (Manage Your Wallet) area #16954

Closed
Miyayes opened this issue Jul 14, 2021 · 1 comment · Fixed by brave/brave-core#9566
Closed

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 14, 2021

Description

Since this applies to fewer and fewer users over time, this item is too upfront and should be moved out of the way (but retained).

image

Solution

In the Restore tab in the Manage Your Wallet modal area, add a line that says:

View QR Code for iOS Rewards users transferring BAT.

The "View QR code" will be a hyperlink that displays the QR code as it currently works.

Placement: This line should go under the paragraph ending in "... before restoring" on a new paragraph line.

image

Discussion

Please let me know if you think we should add a completely separate tab instead.

@stephendonner
Copy link

Unable to fully test the QR code, as the QA team doesn't readily have a 1.25 build of Brave on iOS, to use.

Verified PASSED using the testplan at brave/brave-core#9566 with

Brave 1.29.75 Chromium: 93.0.4577.58 (Official Build) (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. Launched Brave
  2. Visited brave://rewards
  3. Verified that QR code section doesn't appear in Settings page
  4. Clicked the gear/settings icon
  5. Selected the Restore tab in the modal
  6. Verified that QR code link looks as expected
  7. Clicked the QR code link
  8. Verify that appropriate QR code displays
  9. Verify that QR code functions as expected

Checked that the QR code was visible, in the right place, and looked viable, but did NOT test the userdrain portion.

example example example
Screen Shot 2021-08-30 at 2 20 02 PM Screen Shot 2021-08-30 at 2 20 09 PM Screen Shot 2021-08-30 at 2 20 12 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants