Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement new tipping banner (Phase 1) #17070

Closed
5 tasks done
Miyayes opened this issue Jul 21, 2021 · 3 comments · Fixed by brave/brave-core#14967
Closed
5 tasks done

[Android] Implement new tipping banner (Phase 1) #17070

Miyayes opened this issue Jul 21, 2021 · 3 comments · Fixed by brave/brave-core#14967

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 21, 2021

Description

The tipping banner on Android needs to be updated to be at parity with the tipping banner on desktop. This will be split into different phases. This issue is for Phase 1, which includes:

Deferred to follow-up issues (later phases)

  1. Multiple default backgrounds (not just the blue background)
  2. Dedicated Monthly tip change amount UI (see figure 1 below)
  3. Fetching actual cover photo set by the creator
  4. Confetti animation on success

Figure 1:

@aman-m1
Copy link

aman-m1 commented Feb 24, 2022

@deeppandya is sitting on (no offence) so many important updates. Like #17408 and #15618. I give you an icecream to chill and a rocket for speed.

@Miyayes
Copy link
Collaborator Author

Miyayes commented Aug 1, 2022

Custom tipping amount feature: #16021 @deeppandya @sujitacharya2005

@Miyayes Miyayes changed the title [Android] Implement new tipping banner (desktop parity): fetch tip amounts, banner image, description, add new styling [Android] Implement new tipping banner (Phase 1) Sep 15, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Sep 27, 2022
@Miyayes Miyayes closed this as completed Sep 27, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 17, 2022

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.46.114

Logged #26744
Logged #26833
Logged #26740

Clean profile

One-time tips using default tip values_PASSED
  • Confirmed that the new tipping banner UI Tip amounts are shown as expected
  • Confirmed verified checkmark is shown on the tipping banner when verified creator is opened
  • Confirmed that controls are working as expected on the tipping banner
  • Confirmed that user can send one-time tips using default values via new tipping banner
  • Confirmed that user can tweet about the creator support by clicking on the tweet about your support button
  • Confirmed that one-time tip is shown in tips panel, rewards summary, BR panel, brave://rewards-internals page
  • Confirmed that there is no animation on the tipping success UI, which is expected as this is deferred to next phase
  • Confirmed creators photo is not shown on the tipping banner, which is expected as this is deferred to next phase
  • Confirmed creators tipping banner background image is not shown, which is expected as this is deferred to next phase
  • There is not close (x) button in the tipping banner, logged Close (x) button should be present in the tipping banner #26744
  • Support this creator header is not shown in the tipping banner, logged Support this creator header is not shown in the tipping banner #26740
Example Example Example Example Example Example Example
Screenshot_20221117_213807 Screenshot_20221117_213816 Screenshot_20221117_214037 Screenshot_20221117_214856 Screenshot_20221117_214928 Screenshot_20221117_214934 Screenshot_20221117_215013
One-time tips using custom tip values_PASSED
  • Confirmed that the custom tipping banner UI Tip amounts are shown as expected
  • Confirmed verified checkmark is shown on the tipping banner when verified creator is opened
  • Confirmed that controls are working as expected for the custom tips
  • Confirmed that user can send one-time tips using custom tip values via new tipping banner
  • Confirmed that user can tweet about the creator support by clicking on the tweet about your support button
  • Confirmed that one-time tip is shown in tips panel, rewards summary, BR panel, brave://rewards-internals page
  • Confirmed that warning messag Minimum tip amount is 0.25 BAT is shown when user tried to send custom tip amount < 0.24 BAT
Example Example Example Example Example Example Example Example
Screenshot_20221117_222059 Screenshot_20221117_222108 Screenshot_20221117_222115 Screenshot_20221117_222123 Screenshot_20221117_222147 Screenshot_20221117_222147 Screenshot_20221117_222154 Screenshot_20221117_222210
Monthly tips using default tip values_PASSED
  • Confirmed that user can send one-time tips using default tip values via new tipping banner
  • Confirmed that user can tweet about the creator support by clicking on the tweet about your support button
  • Confirmed that one-time tip is shown in tips panel, rewards summary, BR panel, brave://rewards-internals page
  • Confirmed that warning messag Minimum tip amount is 0.25 BAT is shown when user tried to send custom tip amount < 0.24 BAT
Example Example Example Example Example Example Example Example Example
Screenshot_20221117_223736 Screenshot_20221117_223751 Screenshot_20221117_223759 Screenshot_20221117_223814 Screenshot_20221117_223824 Screenshot_20221218_223959 Screenshot_20221218_224004 Screenshot_20221218_224121 Screenshot_20221218_224708
Monthly tips using custom tip values_PASSED
  • Confirmed that user can send one-time tips using custom tip values via new tipping banner
  • Confirmed that user can tweet about the creator support by clicking on the tweet about your support button
  • Confirmed that one-time tip is shown in tips panel, rewards summary, BR panel, brave://rewards-internals page
  • Confirmed that warning messag Minimum tip amount is 0.25 BAT is shown when user tried to send custom tip amount < 0.24 BAT (screenshot is added in the above case :))
  • Once user set the monthly tip, if they open tipping banner and send a monthly tip to a creator then Change amount UI is not shown, which is expected for this phase as this implementation is deferred to next phase
  • Decimal value is not shown in the Monthly Tip dropdown in the BR panel, logged Decimal value is not shown in the Monthly Tip dropdown in the BR panel  #26833
Example Example Example Example Example Example Example Example Example
Screenshot_20221218_225749 Screenshot_20221218_225755 Screenshot_20221218_225805 Screenshot_20221218_225814 Screenshot_20230117_225853 Screenshot_20230117_225859 Screenshot_20230117_225904 Screenshot_20230117_225920

Upgrade profile

  • Confirmed one time tip/monthly tips sent in 1.45.x are reflected in the 1.46.x profile correctly
  • Confirmed user tip amount is shown correctly in the tipping banner
  • Confiremed user can send one-time tip/monthly tips to verified creators

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.46.114

Known issues/deferred to next phase:

  • Confirmed that there is no animation on the tipping success UI, which is expected as this is deferred to next phase
  • Confirmed creators photo is not shown on the tipping banner, which is expected as this is deferred to next phase
  • Confirmed creators tipping banner background image is not shown, which is expected as this is deferred to next phase
  • Once user set the monthly tip, if they open tipping banner and send a monthly tip to a creator then Change amount UI is not shown, which is expected for this phase as this implementation is deferred to next phase
Example Example Example Example Example Example Example Example Example Example Example
Screenshot_20221117-233215_Brave - Beta Screenshot_20221117-233227_Brave - Beta Screenshot_20221117-233309_Brave - Beta Screenshot_20221117-233323_Brave - Beta Screenshot_20221117-233514_Brave - Beta Screenshot_20221117-233529_Brave - Beta Screenshot_20221117-233537_Brave - Beta Screenshot_20221117-233548_Brave - Beta Screenshot_20221117-233614_Brave - Beta Screenshot_20221117-233623_Brave - Beta Screenshot_20221117-233633_Brave - Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants