Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor component-updater code #17462

Closed
jumde opened this issue Aug 12, 2021 · 1 comment · Fixed by brave/brave-core#9933
Closed

Refactor component-updater code #17462

jumde opened this issue Aug 12, 2021 · 1 comment · Fixed by brave/brave-core#9933

Comments

@jumde
Copy link
Contributor

jumde commented Aug 12, 2021

Description

  1. In brave-core, we set the component-updater URLs in browser/net/brave_common_static_redirect_network_delegate_helper.cc. This can be simplified by setting the URLs using the command line flag.

  2. For the service-key, we can override BuildUpdateCheckExtraRequestHeaders to add the header to the updater requests.

Test Plan

Specified here - https://github.com/brave/internal/issues/802

@stephendonner
Copy link

stephendonner commented Oct 12, 2021

Verified PASSED using

Brave 1.32.66 Chromium: 95.0.4638.40 (Official Build) nightly (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Verification notes in https://github.com/brave/internal/issues/802#issuecomment-941549684

Verification passed on

Brave | 1.32.78 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | Windows 10 Version 21H1 (Build 19043.1288)

Verification notes in https://github.com/brave/internal/issues/802#issuecomment-941549684


Verified PASSED using

Brave 1.32.87 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Linux

Verification notes in https://github.com/brave/internal/issues/802#issuecomment-941549684

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment