A Brave user agent is sent in Chromecast SSDP packets

[fmarier]

Description

Instead of using the regular user agent (like we send to websites, i.e. the Chrome one), Chromecast SSDP packets create their own user agent manually: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/media/router/discovery/dial/dial_service.cc;l=111-128;drc=46bbb9795fcc1934c6cfbec096764f888c4d400a

Steps to Reproduce

1. Open Wireshark, filter for ssdp
2. Start the browser
3. Expand the "Simple Service Discovery Protocol" entry
4. Look for USER-AGENT

Actual result:

Expected result:

We should either send our regular web user agent:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36

or perhaps it would be better for compatibility with Chromecast devices to pretend to be a Chrome browser. This is what Chrome sends:

USER-AGENT: Google Chrome/93.0.4577.63 Linux

[ShivanKaul]

Thanks for filing @fmarier! Also noting here that on Mac the channel info is included for the user agent:

[LaurenWags]

Issue still reproduces with

Brave | 1.64.43 Chromium: 121.0.6167.139 (Official Build) nightly (x86_64)
-- | --
Revision | 190a1d5dbad671a0994283b793d4e66e98b82371
OS | macOS Version 13.6.4 (Build 22G513)

Steps:

1. Open Wireshark, filter for ssdp
2. Launch Nightly
3. Enable Media Router under brave://settings/extensions
4. Relaunch as required
5. Expand the "Simple Service Discovery Protocol" entry
6. Look for USER-AGENT

[stephendonner]

Verified PASSED using

Brave	1.65.77 Chromium: 123.0.6312.29 (Official Build) nightly (x86_64) 
Revision	031ef8c7876fbefaede9ac29292258fe299e06fc
OS	macOS Version 11.7.10 (Build 20G1427)

Steps:

1. installed 1.65.77
2. launched Brave
3. launched Wireshark
4. filtered to ssdp
5. opened brave://settings/extensions
6. set Media Router to Enabled
7. clicked Relaunch
8. examined the ssdp packets

Confirmed USER-AGENT: Google Chrome/124.0.6355.0 Mac OS X\r\n

example	example	example

[MadhaviSeelam]

Verification PASSED using

Brave | 1.65.93 Chromium: 123.0.6312.58 (Official Build) beta (64-bit)
-- | --
Revision | a6eee503125f9441360861f96cfdcccf43b6fee0
OS | Windows 11 Version 23H2 (Build 22631.3296)

Steps:

1. installed 1.65.93
2. launched Brave
3. launched Wireshark
4. filtered to ssdp
5. opened brave://settings/extensions
6. set Media Router to Enabled
7. clicked Relaunch
8. examined the ssdp packets

Confirmed USER-AGENT: Google Chrome/123.0.6312.58 Windows

example	example	example

[hffvld]

Hi @fmarier does it apply to Android? I don't think we can cast with a mobile browser.

[fmarier]

Hi @fmarier does it apply to Android? I don't think we can cast with a mobile browser.

Good question. I may have filed this as Desktop & Android by mistake. I don't remember ever testing this on Android.

[MadhaviSeelam]

Verification PASSED using

Brave	1.65.96 Chromium: 123.0.6312.86 (Official Build) beta (64-bit) 
Revision	5d9143e1a0812c53bdc27fd5384591254306a88c
OS	Linux

Steps:

1. installed 1.65.96
2. launched Brave
3. launched Wireshark
4. selected ens33 for ...using this filter
5. filtered to ssdp
6. opened brave://settings/extensions
7. set Media Router to Enabled
8. clicked Relaunch
9. examined the ssdp packets

Confirmed USER-AGENT: Google Chrome/123.0.6312.86 Linux

example	example	example

[hffvld]

Hi @fmarier, @SergeyZhukovsky and @kjozwiak I spent some time trying to connect Android to Wireshark and capture traffic data. I couldn't figure out how to get SSDP protocol info, I only see MDNS protocol running on the device. I'm not sure if we must use rooted device to see all traffic info or if my setup is incorrect. So, any help is appreciated.

---

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240305.005 release-keys
Brave build: 1.65.103
Chromium: 123.0.6312.105 (Official Build) beta (64-bit) 

---

Android	MacOS