Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promoCode is never claimed after closing browser just after install #1811

Closed
btlechowski opened this issue Oct 23, 2018 · 2 comments · Fixed by brave/brave-core#724
Closed

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. (Important) Uninstall Brave Browser with User Data to have a Clean install
    image
  2. (On Windows )Download stub/mini installer and rename it to BraveBrowserSetup-KAM253.exe
  3. Run the stub/mini installer
  4. Close Brave as soon as it is started
  5. Run Brave and wait for promoCode to disappear
  6. Check Local State file for promo_code

Note: promoCode and Local State files are located in AppData\Local\BraveSoftware\Brave-Browser\User Data\ on Windows

Actual result:

promoCode is never claimed
promo_code is not added to Local State

Expected result:

promoCode is claimed
promo_code is added to Local State

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

@kjozwiak Can you check on Mac?
cc @srirambv @LaurenWags @GeetaSarvadnya @emerick

@emerick
Copy link
Contributor

emerick commented Oct 24, 2018

This is because we only look for the promoCode file on "first run". We should probably just look for it as long as we don't have a download_id in our local state, though.

@GeetaSarvadnya
Copy link

Verification Passed on

Brave 0.55.21 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment