Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock Brave custom ad notification position to the main display #18845

Closed
tmancey opened this issue Oct 18, 2021 · 4 comments · Fixed by brave/brave-core#11101
Closed

Lock Brave custom ad notification position to the main display #18845

tmancey opened this issue Oct 18, 2021 · 4 comments · Fixed by brave/brave-core#11101
Assignees
@tmancey
Labels
1_point For Agile sizing enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.34.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Oct 18, 2021 •
edited
Loading

Lock Brave custom ad notification position to the main display (allow user to unblock via brave://flags)
@tmancey tmancey changed the title Lock Brave custom ad notifications to the main display Lock Brave custom ad notification position to the main display Oct 18, 2021
@jsecretan jsecretan added the 1_point For Agile sizing label Oct 19, 2021
@tmancey tmancey removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Oct 26, 2021
@jsecretan
Copy link

Just to clarify, this should be the display where Brave is (mostly if spanning windows). We should probably change "main display" just to clarify that it is not always on what the OS would consider to be the primary display.

@tmancey tmancey mentioned this issue Nov 15, 2021
Merged
24 tasks
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude and removed feature/ads labels Nov 15, 2021
@tmancey tmancey self-assigned this Nov 15, 2021
@tmancey tmancey added this to the 1.34.x - Nightly milestone Nov 16, 2021
@btlechowski
Copy link

Verification passed on

Brave 1.34.63 Chromium: 96.0.4664.110 (Official Build) beta (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Windows 10 Version 20H2

Verified for Monitor 1 as default for AdNotifications/should_support_multiple_displays/false
Verified custom ads are glued to Monitor 1

4k_default_0 4k_default_1 4k_default_2 4k_default_3 4k_default_4

Verified for Monitor 2 as default for AdNotifications/should_support_multiple_displays/false
Verified custom ads are glued to Monitor 2

2k_default_0 2k_default_1 2k_default_2 2k_default_3

Verified for Monitor 2 as default for AdNotifications/should_support_multiple_displays/true
Verified custom ads can be dragged between Monitor 1 and 2
Used commandline:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --brave-today-host=brave-today-cdn.bravesoftware.com --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_support_multiple_displays/true"
2k_default_flag_0 2k_default_flag_1

@stephendonner
Copy link

stephendonner commented Dec 23, 2021 •
edited
Loading

Verification passed on

Brave 1.34.63 Chromium: 96.0.4664.110 (Official Build) beta (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Windows 10 Version 20H2

Verified for Monitor 1 as default for AdNotifications/should_support_multiple_displays/false
Verified custom ads are glued to Monitor 1

monitor 1 default top right top left bottom left bottom right
Screen Shot 2021-12-23 at 11 47 51 AM Screen Shot 2021-12-23 at 11 20 59 AM Screen Shot 2021-12-23 at 11 27 30 AM Screen Shot 2021-12-23 at 11 39 50 AM Screen Shot 2021-12-23 at 11 33 35 AM

Verified for Monitor 2 as default for AdNotifications/should_support_multiple_displays/false
Verified custom ads are glued to Monitor 2

monitor 2 default top right top left bottom left bottom right
Screen Shot 2021-12-23 at 11 47 58 AM Screen Shot 2021-12-23 at 12 09 14 PM Screen Shot 2021-12-23 at 12 09 14 PM Screen Shot 2021-12-23 at 12 15 46 PM Screen Shot 2021-12-23 at 12 22 35 PM

Verified for Monitor 2 as default for AdNotifications/should_support_multiple_displays/true
Verified custom ads can be dragged between Monitor 1 and 2
Used commandline:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --brave-today-host=brave-today-cdn.bravesoftware.com --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_support_multiple_displays/true"
example example (2nd monitor not displayed in screenshot; note position of ad)
Screen Shot 2021-12-23 at 12 46 36 PM Screen Shot 2021-12-23 at 12 47 05 PM

@btlechowski
Copy link

Verification passed on

Brave 1.34.71 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Ubuntu 18.04 LTS

Verified for Monitor 1 as default for AdNotifications/should_support_multiple_displays/false
Verified custom ads are glued to Monitor 1

default_1_1 default_1_2 default_1_3 default_1_4

Verified for Monitor 2 as default for AdNotifications/should_support_multiple_displays/false
Verified custom ads are glued to Monitor 2

default_2_1 default_2_2 default_2_3 default_2_4

Verified for Monitor 2 as default for AdNotifications/should_support_multiple_displays/true
Verified custom ads can be dragged between Monitor 1 and 2
Used commandline:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --brave-today-host=brave-today-cdn.bravesoftware.com --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_support_multiple_displays/true"
flag_1_1 flag_1_2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
1_point For Agile sizing enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Lock Brave custom ad notification position to the main display brave/brave-core
5 participants
@jsecretan @stephendonner @tmancey @LaurenWags @btlechowski