Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a visible border when toggling on/off Search with DuckDuckGo in a private window #18884

Closed
Tonev opened this issue Oct 20, 2021 · 2 comments

Comments

@Tonev
Copy link
Contributor

Tonev commented Oct 20, 2021

Description

Noticed a visible orange border when toggling on/off Search with DuckDuckGo in a private window.

Steps to Reproduce

  1. Make sure you're eligible to use Search with DuckDuckGo in a private window (Refresh Private Window New Tab page #18486).
  2. Toggle on/off Search with DuckDuckGo.
  3. Check if there is a visible border.

Actual result:

1

Expected result:

2

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave 1.31.87 Chromium: 95.0.4638.54 (Official Build) (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Windows 7 Service Pack 1 (Build 7601)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? I can't test because I don't meet requirement 1 from STR.
  • Can you reproduce this issue with the nightly channel? I can't test because I don't meet requirement 1 fromSTR.
@rebron
Copy link
Collaborator

rebron commented Oct 28, 2021

Closing as wontfix. The visible orange border there is for accessibility and to show focus on that button.

@Tonev
Copy link
Contributor Author

Tonev commented Oct 29, 2021

@rebron

If this is intentional behavior, at least fix the border so it doesn't cut through the circle part of the button as it is currently, you can see that from the screenshot I've provided under Actual result. I highly doubt the current implementation of the border is intentional, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants