Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make launch in Tor button smaller #18923

Closed
karenkliu opened this issue Oct 22, 2021 · 2 comments · Fixed by brave/brave-core#10710
Closed

Make launch in Tor button smaller #18923

karenkliu opened this issue Oct 22, 2021 · 2 comments · Fixed by brave/brave-core#10710
Assignees
Labels
design A design change, especially one which needs input from the design team feature/private-browsing OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude

Comments

@karenkliu
Copy link

karenkliu commented Oct 22, 2021

Description

The button to launch a webpage in Tor takes up a lot of space in the URL bar and competes with other actions. Make the button smaller to allow for more space

Steps to Reproduce

  1. Go to a page that can launch in Tor
  2. See the launch in Tor button appear

Actual result:

Screen Shot 2021-07-14 at 9 41 50 AM

Expected result:

Screen Shot 2021-10-21 at 5 47 27 PM

Plus, tooltip should be a longer more descriptive message when hovering over the button with a mouse.

Reproduces how often:

Easily

Brave version (brave://version info)

all versions

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Assets

Figma: https://www.figma.com/file/5THkuEtO2Ewn9LfqrHZP9a/?node-id=1042%3A19759

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. design A design change, especially one which needs input from the design team labels Oct 26, 2021
@rebron rebron assigned nullhook and unassigned rebron Oct 26, 2021
@nullhook
Copy link

cc @diracdeltas

@stephendonner
Copy link

Verified PASSED using

Brave 1.33.51 Chromium: 95.0.4638.69 (Official Build) nightly (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)
new button comparison to release
Screen Shot 2021-11-02 at 8 49 16 AM Screen Shot 2021-11-02 at 8 49 42 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/private-browsing OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants