Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 96 to Chromium 97 #18954

Closed
mkarolin opened this issue Oct 22, 2021 · 2 comments · Fixed by brave/brave-core#10664
Closed

Upgrade from Chromium 96 to Chromium 97 #18954

mkarolin opened this issue Oct 22, 2021 · 2 comments · Fixed by brave/brave-core#10664
Assignees
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-Win64 QA/Test-Plan-Specified release-notes/exclude

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Oct 22, 2021

Upgrade from Chromium 95 to Chromium 96.

https://chromium.googlesource.com/chromium/src/+log/96.0.4664.35..97.0.4688.2/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop affected areas:

  • Relaunch from Help page when upgrade is available (Mac, non-Mac)
  • Page Info bubble for HTTP(S) and IPFS sites
  • Setting UI: general testing (loads, looks correct)
  • Close button on tabs is shown/works as expected (with many tabs too)
  • brave://about is not missing any links

Android affected areas:

  • Settings UI (first page)
  • New tab page
  • Sync
  • Private page UI
  • Bookmarks
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 16, 2021

Verification passed on

Brave | 1.35.38 Chromium: 97.0.4692.45 (Official Build) nightly (64-bit)
-- | --
Revision | 513579c4234d36379b32e422772546e885cef641-refs/branch-heads/4692@{#802}
OS | Windows 10 Version 21H2 (Build 19044.1387)

Relaunch from Help page when upgrade is available
  • Confirmed brave is upgraded successfully when an upgrade is available in brave://settings/help
Example Example
image image
Page Info bubble for HTTP(S) and IPFS sites
  • Confirmed V2 version dialog for page info version is displayed as expected

Secure site

Example Example
image image

Non-secure site
image

IPFS sites

Example Example
image image
Example Example
image image
brave://about

Confirmed all the links are present in brave://about except the links below, which is expected as per the https://bravesoftware.slack.com/archives/C7VLGSR55/p1639677663306800

brave://appcache-internals
brave://devices
brave://network-error
brave://ppapiflashcrash/
brave://ppapiflashhang/
Close button on tabs
Example Example
image image
Setting UI
Example Example
image image

@LaurenWags
Copy link
Member

LaurenWags commented Dec 21, 2021

Labelling QA/No and release-notes/exclude as this is superseded by #19998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment