Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to handle native wallet flag and admin policy for controlling it #19035

Closed
srirambv opened this issue Oct 27, 2021 · 2 comments
Closed
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. suggestion

Comments

@srirambv
Copy link
Contributor

With Wallet being enabled by default we should consider

  1. Remove the flag entirely
  2. Alternately change the flag to handle wallet functionality in browser

1 is pretty straight forward we won't have the flag in brave://flags
2 would be to make the flag more generic like enabling all wallet functionality or disabling all wallet functionality in the browser. So setting this flag to disable would remove the entry for brave://setting/wallet from browser settings and won't load brave://wallet

In addition to the above we should consider adding an admin policy to control the flag similar to what we did for Tor (#454 & #12426)

cc: @brave/crypto-wallets

@srirambv srirambv added suggestion feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Oct 27, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 29, 2021
@bbondy
Copy link
Member

bbondy commented Nov 3, 2021

We should also review that changes in this PR are covered by the flag: brave/brave-core#10852

brianjohnson  1:59 PM
shouldn't some of these like https://github.com/brave/brave-core/pull/10852/files#diff-d665c90359b8b4eb62a748f6fab0151aa41ed2b3cd3de704fd320ba176cd51e6R121 be behind the feature flag?
2:00
same here https://github.com/brave/brave-core/pull/10852/files#diff-ec9781bb0072659ae6dd0dd4607a48f1efc577d22dbb70d61688e33949a1fb36R79
2:01
https://github.com/brave/brave-core/pull/10852/files#diff-a41e51332bd7613044392e5f68853e6155e964eff947f0093b5b887ca6ebf3e8R312
2:01
https://github.com/brave/brave-core/pull/10852/files#diff-993c17882cc3b6e092ae1048b78ccf8d0501a9b33c46597f427f49065e2e8599R23
2:02
https://github.com/brave/brave-core/pull/10852/files#diff-9f59402a3e195c8f1fd5f29bc43270777f4bd61925130803869ae2e5c6f4cb5dL18

@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 5, 2021
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 18, 2022
@srirambv
Copy link
Contributor Author

This is managed via #25383. Closing the issue as stale

@srirambv srirambv closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Oct 25, 2023
@srirambv srirambv added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. suggestion
Projects
Archived in project
Development

No branches or pull requests

2 participants