Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "Re-Type password" to "Confirm password" #19068

Closed
jamesmudgett opened this issue Oct 28, 2021 · 1 comment · Fixed by brave/brave-core#10755
Closed

Rename "Re-Type password" to "Confirm password" #19068

jamesmudgett opened this issue Oct 28, 2021 · 1 comment · Fixed by brave/brave-core#10755
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.32.x - Release

Comments

@jamesmudgett
Copy link

Missed string correction
@jamesmudgett jamesmudgett added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Oct 28, 2021
@jamesmudgett jamesmudgett changed the title Rename "Re-Type password" to "Verify password" Rename "Re-Type password" to "Confirm password" Oct 28, 2021
@Douglashdaniel Douglashdaniel added front-end-change This task is a front end task and doesn't need any C++ changes QA/Yes release-notes/exclude and removed OS/Android Fixes related to Android browser functionality labels Oct 29, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Oct 29, 2021
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.33.x - Nightly milestone Oct 29, 2021
@stephendonner
Copy link

stephendonner commented Oct 29, 2021 •
edited
Loading

Verified PASSED using

Brave 1.33.46 Chromium: 95.0.4638.69 (Official Build) nightly (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)

Screen Shot 2021-10-29 at 9 22 50 AM

Verified PASSED using

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 20H2 (Build 19042.1288)

Confirmed the string changes on brave://wallet/crypto/onboarding

confirm-password

Verified PASSED using

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Screen Shot 2021-11-15 at 3 34 37 PM

@kjozwiak kjozwiak mentioned this issue Oct 29, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

Updated Confirm Password Strings brave/brave-core
4 participants
@jamesmudgett @stephendonner @kjozwiak @Douglashdaniel