Integrate first party ephemeral storage with domain block functionality

[goodov]

Add logic to automatically enable first party ephemeral storage (1PES) for a domain when a user proceeds the blocked top level domain interstitial.

Related:
#14134
#15906

[stephendonner]

Hi @goodov; mind providing us with a test plan for this one? Thanks!

[goodov]

Hi @goodov; mind providing us with a test plan for this one? Thanks!

Sure! Some context first: currently if a user visits a first-party-blocked website, we show an interstitial in Aggressive blocking mode, however in Standard blocking the website is loaded as usual. The change we're adding here will enable 1PES for such websites in Standard blocking mode if no data (cookies, localStorage) was stored for a website previously.

Test cases

Prerequisites:

1. Enable features on brave://flags: First Party Ephemeral Storage, Domain blocking using First Party Ephemeral Storage.

Case 1

1. Open any website (that was not previously opened in a browser profile) from this list
2. Expect the website is added in Sites that clear cookies when you close them section at brave://settings/cookies:
   
3. Expect no cookies or localStorage data is stored for a website.

Case 2

1. Enable Aggressive blocking mode
2. Open any website (that was not previously opened in a browser profile) from the list
3. Expect a blocking interstitial is visible:
   
4. Expect the website is added in Sites that clear cookies when you close them section at brave://settings/cookies when Proceed is pressed without Don't warn me about this site again checkbox.
5. Expect no cookies or localStorage data is stored for a website.

Case 3

1. Enable Aggressive blocking mode
2. Open any website (that was not previously opened in a browser profile) from the list
3. Expect a blocking interstitial is visible
4. Expect the website is not added in Sites that clear cookies when you close them section at brave://settings/cookies when Proceed is pressed with Don't warn me about this site again checkbox.
5. Expect cookies or localStorage data is stored for a website (if a website does this).

Also a redirect test case can be performed. For example, perform a redirect from any website to a website mentioned in the list, expect it's added automatically in Sites that clear cookies when you close them section.

[stephendonner]

Verification PASSED using

Brave	1.35.79 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision	adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS	Windows 10 Version 20H2 (Build 19042.1415)

Prerequisite

1. installed Brave 1.35.79
2. launched Brave
3. loaded brave://flags
4. set both First Party Ephemeral Storage and Domain blocking using First Party Ephemeral Storage to Enabled
5. relaunch Brave

Case 1: standard mode

1. loaded absurdwater.com (❤️ that domain name!)
2. opened brave://settings/cookies

• Confirmed that absurdwater.com is present under Sites that clear cookies when you close them
• Confirmed that there were no cookies or local storage for absurdwater.com

example	example	example	example

Case 2: aggressive mode

1. enabled Trackers & ads blocked (aggressive) from the Shields dropdown
2. loaded aaxdetect.com
3. confirmed I saw the blocking interstitial
4. clicked the Proceed button
5. opened brave://settings/cookies

• Confirmed aaxdetect.com is added to Sites that clear cookies when you close them in brave://settings/cookies
• Confirmed there were no cookies or local storage for aaxdetect.com

example	example	example	example

Case 3: aggressive mode w/checkbox

1. enabled Trackers & ads blocked (aggressive) from the Shields dropdown
2. loaded aniview.com
3. confirmed I got a blocking interstitial
4. clicked the checkbox for Don't warn me about this site again
5. clicked on Proceed
6. opened brave://settings/cookies

• Confirmed aniview.com is not listed in Sites that clear cookies when you close them
• Confirmed there were cookies stored
• Confirmed a page-view count entry in local storage

example	example	example	example	example	example

Case 4: Redirect

1. loaded stephendonner.github.io (https://github.com/stephendonner/stephendonner.github.io/blob/ede14759e08c9f2f20ad69301ce7717ac113800f/index.html) which has a redirect after 3 seconds to 33across.com
2. confirmed 33across.com was added to Sites that clear cookies when you close them in brave://settings/cookies

example	example	example	example	example

---

Verification PASSED using

Brave	1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision	adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS	Linux

Prerequisite

1. installed Brave 1.35.79
2. launched Brave
3. loaded brave://flags
4. set both First Party Ephemeral Storage and Domain blocking using First Party Ephemeral Storage to Enabled
5. relaunch Brave

Case 1: standard mode

1. loaded 123freeavatars.com
2. opened brave://settings/cookies

• Confirmed that 123freeavatars.com is present under Sites that clear cookies when you close them
• Confirmed that there were no cookies or local storage for 123freeavatars.com

example	example	example	example

Case 2: aggressive mode

1. enabled Trackers & ads blocked (aggressive) from the Shields dropdown
2. loaded 123freeavatars.com
3. confirmed I saw the blocking interstitial
4. clicked the Proceed button
5. opened brave://settings/cookies

• Confirmed 123freeavatars.com is added to Sites that clear cookies when you close them in brave://settings/cookies
• Confirmed there were no cookies or local storage for 123freeavatars.com

example	example	example	example	example

Case 3: aggressive mode w/checkbox

1. enabled Trackers & ads blocked (aggressive) from the Shields dropdown
2. loaded abtasty.com
3. confirmed I got a blocking interstitial
4. clicked the checkbox for Don't warn me about this site again
5. clicked on Proceed
6. opened brave://settings/cookies

• Confirmed abtasty.com is not listed in Sites that clear cookies when you close them
• Confirmed there were cookies stored
• Confirmed a few entries in local storage

example	example	example	example	example	example	example

Case 4: Redirect

1. loaded stephendonner.github.io (https://github.com/stephendonner/stephendonner.github.io/blob/ede14759e08c9f2f20ad69301ce7717ac113800f/index.html) which has a redirect after 3 seconds to 33across.com
2. confirmed 33across.com was added to Sites that clear cookies when you close them in brave://settings/cookies

example	example	example	example	example

---

Verification in progress with

Brave | 1.35.83 Chromium: 97.0.4692.71 (Official Build) beta (x86_64)
-- | --
Revision | adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS | macOS Version 11.6.1 (Build 20G224)

Prerequisite

1. installed Brave 1.35.83
2. launched Brave
3. loaded brave://flags
4. set both First Party Ephemeral Storage and Domain blocking using First Party Ephemeral Storage to Enabled
5. relaunch Brave

Case 1: standard mode

1. loaded unusualtitle.com (from this list)
2. opened brave://settings/cookies

• Confirmed that unusualtitle.com is present under Sites that clear cookies when you close them
• Confirmed that there were no cookies or local storage for unusualtitle.com

example	example	example	example

Case 2: aggressive mode

1. set Trackers & ads blocking to Aggressive from the brave://settings/shields dropdown
2. loaded https://quizzicalzephyr.com
3. confirmed I saw the blocking interstitial
4. clicked the Proceed button
5. opened brave://settings/cookies

• Confirmed https://quizzicalzephyr.com is added to Sites that clear cookies when you close them in brave://settings/cookies
• Confirmed there were no cookies or local storage for https://quizzicalzephyr.com

example	example	example	example	example	example

Case 3: aggressive mode w/checkbox

1. set Trackers & ads blocking to Aggressive from brave://shields
2. loaded abtasty.com
3. confirmed I got a blocking interstitial
4. clicked the checkbox for Don't warn me about this site again
5. clicked on Proceed
6. opened brave://settings/cookies

• Confirmed abtasty.com is not listed in Sites that clear cookies when you close them
• Confirmed there were cookies stored
• Confirmed a few entries in local storage

example	example	example	example	example	example

Case 4: Redirect

1. loaded stephendonner.github.io (https://github.com/stephendonner/stephendonner.github.io/blob/ede14759e08c9f2f20ad69301ce7717ac113800f/index.html) which has a redirect after 3 seconds to 33across.com
2. confirmed 33across.com was added to Sites that clear cookies when you close them in brave://settings/cookies

example	example	example	example	example