Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shields should deeplink to brave://settings/shields #1959

Closed
cezaraugusto opened this issue Nov 1, 2018 · 2 comments · Fixed by brave/brave-extension#80
Closed

shields should deeplink to brave://settings/shields #1959

cezaraugusto opened this issue Nov 1, 2018 · 2 comments · Fixed by brave/brave-extension#80
Assignees
@cezaraugusto
Labels
feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.57.x - Release ...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Nov 1, 2018 •
edited
Loading

there should be a route for there instead of linking to brave://settings/ only

this is a 2-step work:
@cezaraugusto cezaraugusto added feature/shields The overall Shields feature in Brave. feature/global-settings Settings at browser level independent of shields settings labels Nov 1, 2018
@cezaraugusto cezaraugusto self-assigned this Nov 1, 2018
This was referenced Nov 1, 2018
Merged
Merged
@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Nov 2, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@bsclifton bsclifton modified the milestones: 1.x Backlog, 0.58.x - Dev Nov 7, 2018
@bsclifton
Copy link
Member

Updated to be 0.58.x after DEPS was updated with brave/brave-core#820

PR is tagged with uplift-request; let's make sure to modify milestone if that is approved 😄

@srirambv srirambv added the QA/Yes label Nov 9, 2018
@btlechowski
Copy link

btlechowski commented Dec 3, 2018 •
edited by srirambv
Loading

Verification Passed on

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Windows 7

brave://settings/shields worked

Verified passed with

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Mac OS X
  • Verified brave://settings/shields worked.

Verification passed on

Brave 0.57.15 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Linux
  • Verified Global shields settings link navigates to brave://settings/shields

@kjozwiak kjozwiak mentioned this issue Dec 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.57.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

add deeplink to the shields section brave/brave-extension
7 participants
@tildelowengrimm @bbondy @cezaraugusto @bsclifton @srirambv @LaurenWags @btlechowski