Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguate 403 error response codes during Rewards wallet linking #19602

Closed
Miyayes opened this issue Nov 19, 2021 · 4 comments
Closed

Disambiguate 403 error response codes during Rewards wallet linking #19602

Miyayes opened this issue Nov 19, 2021 · 4 comments
Assignees
@szilardszaloki
Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.34.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Nov 19, 2021

Description

https://github.com/brave/internal/issues/805
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 19, 2021
@LaurenWags
Copy link
Member

closing as fixed by brave/brave-core#10941 by @szilardszaloki

@LaurenWags LaurenWags added this to the 1.34.x - Nightly milestone Nov 19, 2021
@LaurenWags
Copy link
Member

labelling QA/Test-All-Platforms after conferring with @szilardszaloki

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 15, 2021
@LaurenWags
Copy link
Member

LaurenWags commented Dec 16, 2021 •
edited by btlechowski
Loading

Verified using

Brave | 1.34.64 Chromium: 96.0.4664.110 (Official Build) beta (x86_64)
-- | --
Revision | d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS | macOS Version 11.6.1 (Build 20G224)

and

Brave | 1.34.67 Chromium: 97.0.4692.56 (Official Build) beta (x86_64)
-- | --
Revision | 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS | macOS Version 11.6.1 (Build 20G224)

Verification notes can be found under https://github.com/brave/internal/issues/805#issuecomment-995958866

Verification passed on


Brave | 1.34.73 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
-- | --
Revision | 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS | Windows 10 Version 21H2 (Build 19044.1415)

Verification notes can be found under https://github.com/brave/internal/issues/805#issuecomment-995958866

Verification passed on

Brave 1.34.67 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Ubuntu 18.04 LTS

Verification notes can be found under https://github.com/brave/internal/issues/805#issuecomment-995958866

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 20, 2021
@stephendonner
Copy link

Removing OS/Android after discussing with @Miyayes and @LaurenWags in https://bravesoftware.slack.com/archives/CNH9Q6REV/p1640748042145500. These modals aren't implemented in 1.34.x, and will be checked in 1.35.x and onward.

@stephendonner stephendonner removed the OS/Android Fixes related to Android browser functionality label Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szilardszaloki szilardszaloki

Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.34.x - Release
Development

No branches or pull requests
6 participants
@stephendonner @szilardszaloki @Miyayes @LaurenWags @btlechowski @GeetaSarvadnya