Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tor to 0.3.4.9 #1974

Closed
riastradh-brave opened this issue Nov 2, 2018 · 6 comments · Fixed by brave/tor_build_scripts#27
Closed

Update tor to 0.3.4.9 #1974

riastradh-brave opened this issue Nov 2, 2018 · 6 comments · Fixed by brave/tor_build_scripts#27
Assignees
@riastradh-brave
Labels
feature/tor priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.59.x - Release ...

Comments

@riastradh-brave
Copy link
Contributor

No description provided.

@riastradh-brave riastradh-brave self-assigned this Nov 2, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@tildelowengrimm tildelowengrimm added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 6, 2018
@riastradh-brave riastradh-brave mentioned this issue Nov 9, 2018
Merged
@bbondy bbondy modified the milestones: 1.x Backlog, 0.59.x - Dev Dec 2, 2018
@bbondy
Copy link
Member

bbondy commented Dec 2, 2018

@mihaiplesa I think the Tor job needs to be run manually for this change so the new binary is bundled.

@bbondy
Copy link
Member

bbondy commented Dec 2, 2018

@riastradh-brave can you please see to it that it gets updated in the extension jenkins job? Mainly by either asking @mihaiplesa or creating a devops issue, or running the job yourself on Jenkins. Thanks!

@mihaiplesa
Copy link
Contributor

Tor extension updated to 1.0.3 via Jenkins job with the following changes:

Import supported extensions from Chrome Web Store
Remove vault-updater-path option, which is no longer needed
Use correct S3 options and brave-core-specific bucket
Use version 0.3.4.8 of the Tor client
Add "Troubleshooting" section to README.md
Issue 35: Tor client v0.3.4.9

@riastradh-brave just gave you access (details on Slack) to our Jenkins instance so you can initiate the build and deploy of future versions.

@LaurenWags
Copy link
Member

@riastradh-brave could you provide a test plan for this issue?

@jumde
Copy link
Contributor

jumde commented Dec 31, 2018

@LaurenWags updated the test plan, let me know if you have any questions.

@srirambv
Copy link
Contributor

srirambv commented Jan 2, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

image

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

image

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riastradh-brave riastradh-brave

Labels
feature/tor priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Update to tor-0.3.4.9. brave/tor_build_scripts
8 participants
@tildelowengrimm @bbondy @mihaiplesa @jumde @srirambv @LaurenWags @riastradh-brave @btlechowski