Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/U issue for microsoft-edge protocol handler implementation #19922

Closed
simonhong opened this issue Dec 6, 2021 · 1 comment · Fixed by brave/brave-core#11445
Closed

F/U issue for microsoft-edge protocol handler implementation #19922

simonhong opened this issue Dec 6, 2021 · 1 comment · Fixed by brave/brave-core#11445

Comments

@simonhong
Copy link
Member

  1. Update patch file BRAVE_DEFAULT_BROWSER_WORKER_H should be in public section (don't need QA)
  2. Move ms_edge_protocol_message_handler.cc to browser/ui/webui/settings (don't need QA)
  3. Notify default protocol change to system - W/o notifying, control panel is not refreshed whe when it's already opened (Need QA)
@stephendonner
Copy link

Verified PASSED using

Brave 1.35.72 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 10 Version 20H2 (Build 19042.1415)

Used the testplan from brave/brave-core#11445.

Steps:

  1. new profile
  2. launched the Control Panel for default apps on Windows 10
  3. confirmed Microsoft Edge was the default handler for the ms-edge protocol
  4. launched Brave
  5. confirmed Brave was not the default handler for the ms-edge protocol
  6. clicked on the Make default button while the Control Panel was open
  7. confirmed Brave dynamically became the MICROSOFT-EDGE protocol handler in the above
example example
19922-1 19922-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment