Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken images for Custom Networks Base Currency #19953

Closed
Douglashdaniel opened this issue Dec 6, 2021 · 1 comment · Fixed by brave/brave-core#11509
Closed

Fix broken images for Custom Networks Base Currency #19953

Douglashdaniel opened this issue Dec 6, 2021 · 1 comment · Fixed by brave/brave-core#11509
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.35.x - Release

Comments

@Douglashdaniel
Copy link

Description

Fix broken icons for Custom Networks Base Currency

  1. Got to brave://settings/wallet
  2. Add a new custom network, add a url for Icon URLs
  3. Go to brave://wallet and switch to the new network
  4. The icon will be broken for the networks base currency.

We currently do not have a way to support icon url's in front end UI but it should at-least default to the placeholder icon

image
@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 6, 2021
@Douglashdaniel Douglashdaniel self-assigned this Dec 6, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Dec 8, 2021
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.35.x - Nightly milestone Dec 9, 2021
@srirambv
Copy link
Contributor

Brave 1.35.89 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified images for custom network's base currency doesn't show a broken icon instead shows the first letter of the token name

@kjozwiak kjozwiak mentioned this issue Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed Broken Icons for Custom Networks brave/brave-core
2 participants
@srirambv @Douglashdaniel