Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same token should not be listed for both Swap from and to #20005

Closed
srirambv opened this issue Dec 9, 2021 · 1 comment · Fixed by brave/brave-core#11801
Closed

Same token should not be listed for both Swap from and to #20005

srirambv opened this issue Dec 9, 2021 · 1 comment · Fixed by brave/brave-core#11801
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Dec 9, 2021

Description

Same token should not be listed for both Swap from and to

Steps to reproduce

  1. Create wallet
  2. Select Swap
  3. Able to set same token for both swap from and to

Actual result

Swap.From.and.To.mp4

Expected result

Similar to Desktop and iOS, token that is set in Swap from should not be listed in Swap to list

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes when released
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.33.103

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky

@srirambv srirambv added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Dec 9, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 9, 2021
@wchen342 wchen342 added this to the 1.36.x - Nightly milestone Jan 11, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Feb 7, 2022

Verification passed the following devices running 1.36.85 x64 Beta build

  • Verified steps from issue description
  • Verified unable to set the same token as Swap To if its already set as Swap From
  • Encountered #20928
Oppo Reno 5 (Android 11) Samsung Tab A (Android 10)
20005-Android.ARM.mp4
20005-Android.Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants