Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow viewing Site Permissions Panel for brave://wallet route #20094

Closed
Douglashdaniel opened this issue Dec 14, 2021 · 2 comments · Fixed by brave/brave-core#11603
Closed
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Douglashdaniel
Copy link

Description

Previously we showed a Connected status and didn't allow viewing the Site Permissions in the panel when your current tabs origin is brave://wallet. It has regressed and needs to be fixed to not allow.

Screen.Recording.2021-12-14.at.2.42.00.PM.mov
@stephendonner
Copy link

Verified PASSED using

Brave 1.35.69 Chromium: 97.0.4692.56 (Official Build) dev (x86_64)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. created a wallet
  3. loaded brave://wallet/crypto/portfolio
  4. clicked on the Wallet icon on the browser toolbar
  5. confirmed I couldn't click on Not connected, but could click on Ethereum, as expected
example example example
Screen Shot 2021-12-30 at 1 58 07 PM Screen Shot 2021-12-30 at 2 00 13 PM Screen Shot 2021-12-30 at 2 00 15 PM

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Windows 11 Version Dev (Build 22523.1000)
  • Verified test plan from brave/brave-core#11603
  • Verified sites permission shows Connected for brave://wallet
  • Verified clicking on it doesn't open account list
  • Verified even when multiple accounts are added site permission doesn't open
  • Verified still able to select Network dropdown and change network

Verification passed on

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Linux
  • Verified test plan from brave/brave-core#11603
  • Verified sites permission shows Connected for brave://wallet
  • Verified clicking on it doesn't open account list
  • Verified even when multiple accounts are added site permission doesn't open
  • Verified still able to select Network dropdown and change network

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants