Indefinitely spinning loading graphic due to uncaught null feed parameter

[stephendonner]

Description

Indefinitely spinning loading graphic due to uncaught null feed parameter

Steps to Reproduce

1. new profile
2. launch Brave
3. open a new-tab page
4. click on Customize
5. disable all sources via the Brave News card/link
6. open Developer Tools, Console tab
7. look at the exception thrown

Actual result:

brave_new_tab.bundle.js:1956 Uncaught Error: Received BraveNewsController_GetFeed_ResponseParams with invalid null field "feed"
    at r.internal.Decoder.decodeStructInline (brave_new_tab.bundle.js:1956:12978)
    at r.internal.interfaceSupport.InterfaceRemoteBase.onMessageReceived (brave_new_tab.bundle.js:1956:36230)
    at r.internal.interfaceSupport.Endpoint.onMessageReceived (brave_new_tab.bundle.js:1956:31278)
    at r.internal.interfaceSupport.Router.onMessageReceived_ (brave_new_tab.bundle.js:1956:28783)
    at r.internal.interfaceSupport.HandleReader.read_ (brave_new_tab.bundle.js:1956:41093)

Expected result:

No exception; some kind of messaging/UX to remind the user to enable more sources?

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.36.5 Chromium: 97.0.4692.56 (Official Build) nightly (x86_64)
Revision	04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS	macOS Version 12.2 (Build 21D5025f)

cc @petemill @mattmcalister @kjozwiak

[jonathansampson]

Note, I am able to reproduce this after enabling only one item.

1. Disable all sources
2. Enable Brave Blog alone

Issue reproduces.

The issue is not limited to Brave Blog; other feeds (below is a sample) will also cause this behavior.

✔ 99 BitCoins		https://99bitcoins.com/feed/
✔ 9to5 Mac		https://9to5mac.com/feed/
✔ ABC News		https://abcnews.go.com/abcnews/topstories
✔ Adventure		https://adventure.com/feed/
✔ Ain't It Cool		https://www.aintitcool.com/node/feed/
✔ Al Jazeera		https://www.aljazeera.com/xml/rss/all.xml

❌ Big Think		https://feeds.feedburner.com/bigthink/main
❌ ArseBlog		https://feeds.feedburner.com/arseblog
❌ Android Central	https://www.androidcentral.com/feed
❌ Apartment Therapy	https://www.apartmenttherapy.com/main.rss
❌ Afar Magazine	https://feeds.feedburner.com/AfarMagazine
❌ Brave Blog		https://brave.com/blog/index.xml

[mattmcalister]

Resolved with Settings upgrade. Closing.