Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary and ugly double outline in local Brave Shields panel when Brave colors is Dark #20332

Open
Tonev opened this issue Jan 5, 2022 · 1 comment

Comments

@Tonev
Copy link
Contributor

Tonev commented Jan 5, 2022

Description

There is an unnecessary white outline in local Brave Shields panel when Brave colors is set to Dark.

Steps to Reproduce

  1. Set Brave colors to Dark via brave://settings/appearance.
  2. Open a random website, and open the Brave Shields panel.
  3. Open and close any of the fields.

Actual result:

Untitled

Expected result:

The white outline should be removed, it's unnecessary and ugly. Brave's orange looks great and is more than enough.

Reproduces how often:

Easily.

Brave version (brave://version info)

Brave 1.33.106 Chromium: 96.0.4664.110 (Official Build) (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Windows 7 Service Pack 1 (Build 7601)
Brave 1.35.72 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 7 Service Pack 1 (Build 7601)
Brave 1.36.14 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Windows 7 Service Pack 1 (Build 7601)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@Tonev
Copy link
Contributor Author

Tonev commented Mar 14, 2022

@rebron

Since this issue is not reproducible with the upcoming UI refresh of Shields, feel free to close if you feel so 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant