-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support overrides to the eTLD+1 exception policy from default adblock filter lists #20426
Comments
Now that the adblock engines are merged (#5461), this should be significantly easier to implement. We can create a new component in https://github.com/brave/brave-core-crx-packager to host the list in plaintext format, then use a new |
@antonok-edm once the component mentioned in the test plan loads, are there additional steps we should take to verify it's working? For example, are there any sites we should check specifically? |
You can check https://www.the-scientist.com/ - there should be no blank bottom bar like there is on Release at the moment. |
Verified with
Steps:
Confirmed the following:
|
Aggressive |
Standard |
brave://components |
---|---|---|
1.56.14
Aggressive |
Standard |
---|---|
Verified on
STEPS:
ACTUAL RESULTS:
Android 8 [phone]
Android 13 [tablet]
Android 14 [phone]
|
Verification
Steps:
Confirmed the following:
|
Aggressive |
Standard |
brave://components |
---|---|---|
1.56.20
Aggressive | Standard |
---|---|
The default adblock engine, into which the default Brave filter lists are loaded, is subject to first-party exceptions to improve web compatibility when in standard Shields blocking mode, as per https://brave.com/privacy-updates/9-web-compat-blocking/.
However, there are cases where we can verify that some first-party resources are an invasion of privacy, cause excessive CPU load, or are otherwise harmful to users and do not break pages - in this case we'd like a way to override the first-party exception policy, and ensure that those requests are blocked anyways in standard Shields mode.
This can be accomplished by loading some filters into a separate adblock engine without the first-party exceptions.
The text was updated successfully, but these errors were encountered: