Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on wallet creation with fingerprint unlock setup on some devices #21153

Closed
SergeyZhukovsky opened this issue Feb 17, 2022 · 2 comments · Fixed by brave/brave-core#12321
Closed
Assignees
Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

An original discussion is here https://community.brave.com/t/brave-browser-wallet-will-not-let-me-create-a-wallet/340575
Basically the user reported that they are not able to create a wallet, it crashes on onboarding.
Crash stack:
https://brave.sp.backtrace.io/p/brave/debug?time=hour&filters=(_rxid%3D%225d310000-7c5a-c307-0000-000000000000%22%2Cplat%3DAndroid)&debug=(%222fb9c52%22,0,0)

@SergeyZhukovsky SergeyZhukovsky added crash priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 17, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Feb 17, 2022
@SergeyZhukovsky SergeyZhukovsky added this to the 1.37.x - Nightly milestone Feb 17, 2022
@kjozwiak kjozwiak modified the milestones: 1.37.x - Nightly, 1.35.x - Release #4, 1.35.x - Release #5, 1.36.x - Release Feb 19, 2022
@kjozwiak
Copy link
Member

This was originally uplifted/scheduled to go into a 1.35.x HF but never ended up being released. It will go out via 1.36.x as we won't be having another 1.35.x release at this point.

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.36.105 x64 nightly build

  • Verified able to create wallet without crash when Fingerprint unlock is enabled
  • Verified able to create wallet without crash when Fingerprint unlock is not enabled
  • Verified when fingerprint is not enabled, locking and unlocking the wallet doesn't cause any crash

Verification passed on Samsung Tab A with Android 10 running 1.36.105 x64 nightly build

  • Verified able to create wallet without crash when Facial recognition is disabled
  • Verified with facial unlock disabled on the device, locking and unlocking the wallet doesn't cause any crash

@bbondy bbondy changed the title Crash on wallet creation Crash on wallet creation with fingerprint unlock Mar 1, 2022
@bbondy bbondy changed the title Crash on wallet creation with fingerprint unlock Crash on wallet creation with fingerprint unlock setup on some device Mar 1, 2022
@bbondy bbondy changed the title Crash on wallet creation with fingerprint unlock setup on some device Crash on wallet creation with fingerprint unlock setup on some devices Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants