opening a NTP page in normal mode from PB cycles through various images before displaying

[kjozwiak]

Description

When running through/verifying brave/brave-core#12758 (comment), I ran into an issue several times where opening an NTP in normal mode would cycle through several NTP pages where it eventually would crash Brave.

Steps to reproduce

1. run through the STR/Cases mentioned via Tap on the Private tab favicon on the top right corner in the normal window opens up the normal window with Private tab content #21877 (comment)
2. once you start switching between PB/normal mode, you'll notice the the NTP cycle through several images

In essence, you need to open a few normal tabs from PB to Normal mode and you'll eventually start seeing the issue.

Actual result

See example of the issue occurring --> https://youtu.be/mle9s1EYlgs

Expected result

Only a single NTP image should load within the tab. It shouldn't be cycling through several images.

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? Yes
• Can you reproduce this issue with the current Play Store Beta version? Yes
• Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Samsung Galaxy Tablet A
• Android version: Android 12

Brave version

• 1.36.116 Chromium 99.0.4844.74 - Reproduced
• 1.39.9 Chromium: 100.0.4896.46 - Reproduced

Website problems only

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @SergeyZhukovsky @samartnik @anthonypkeane @bsclifton @Uni-verse @srirambv

[iefremov]

@kjozwiak does it still happen?