Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on VPN-location radio buttons doesn't work #22632

Closed
stephendonner opened this issue Apr 29, 2022 · 3 comments · Fixed by brave/brave-core#13436
Closed

Clicking on VPN-location radio buttons doesn't work #22632

stephendonner opened this issue Apr 29, 2022 · 3 comments · Fixed by brave/brave-core#13436

Comments

@stephendonner
Copy link

Description

Clicking on VPN-location radio buttons doesn't work

Steps to Reproduce

  1. install 1.39.86
  2. launch Brave
  3. go through the full setup steps to purchase and use a VPN credential from account.brave.software
  4. click on the VPN icon in the browser toolbar
  5. click on the VPN-location selectors' radio buttons

Actual result:

Nothing happens; the click event is eaten?

radio-buttons-no-clicks

Expected result:

Clicking on the radio buttons for each VPN location should select it

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.86 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

cc @nullhook @rebron @bsclifton @aguscruiz

@stephendonner stephendonner added bug needs-text-change This change requires some careful wording. QA/Yes QA/Test-Plan-Specified OS/Desktop feature/vpn and removed needs-text-change This change requires some careful wording. labels Apr 29, 2022
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label May 19, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 25, 2022

++reproduced on Windows 10 x64

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.41.17 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)

Followed my original steps to reproduce, and confirmed clicking on the radio buttons selected the correct VPN location

change-vpn-location

Note: will file and cross-link a follow-up issue for the lack of focus rings/events for the radio buttons themselves, via keyboard navigation.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 21, 2022

Verification PASSED using

Brave | 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.739)

Reproduced the issue in 1.40.100 Chromium: 102.0.5005.125 beta

2022-06-21_16h55_18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants