Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN Settings (gear) icon is missing its tooltip #22636

Closed
stephendonner opened this issue Apr 30, 2022 · 2 comments · Fixed by brave/brave-core#17582
Closed

VPN Settings (gear) icon is missing its tooltip #22636

stephendonner opened this issue Apr 30, 2022 · 2 comments · Fixed by brave/brave-core#17582

Comments

@stephendonner
Copy link

Description

VPN Settings (gear) icon is missing its tooltip

Steps to Reproduce

  1. install 1.40.16
  2. launch Brave
  3. set brave://flags/#brave-vpn to Enabled
  4. click on Relaunch
  5. click on the VPN icon in the browser toolbar
  6. hover over the Settings (gear) icon in the doorhanger panel

Actual result:

No tooltip

Screen Shot 2022-04-29 at 11 45 18 PM

Expected result:

Perhaps VPN Settings or just Settings, as a tooltip? We need to do what's best for accessibility (if Settings would be too ambiguous with a screenreader, for instance).

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.40.16 Chromium: 101.0.4951.41 (Official Build) nightly (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 12.4 (Build 21F5063e)

cc @aguscruiz @bsclifton @nullhook

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.51.58 Chromium: 112.0.5615.29 (Official Build) nightly (x86_64)
Revision 8a59304c62e066962363d2fd8edd8e7b459c42bd-refs/branch-heads/5615@{#497}
OS macOS Version 13.3 (Build 22E252)

Steps:

  1. installed 1.51.58
  2. launched Brave
  3. restarted Brave to enable VPN via Griffin
  4. loaded account.brave.com
  5. logged in using stephen-prod@mailinator.com
  6. linked account via Refresh Brave VPN button
  7. clicked on the VPN button
  8. hovered over the icon

Confirmed the tooltip text of Settings when hovering over the Gears/Settings icon

Screenshot 2023-03-23 at 5 13 08 PM

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.51.58 Chromium: 112.0.5615.29 (Official Build) nightly (64-bit)
Revision 8a59304c62e066962363d2fd8edd8e7b459c42bd-refs/branch-heads/5615@{#497}
OS Windows 10 Version 22H2 (Build 19045.2728)

Steps:

  1. installed 1.51.58
  2. launched Brave
  3. restarted Brave to enable Brave VPN via Griffin
  4. loaded account.brave.com
  5. logged in using stephen-prod@mailinator.com
  6. linked account via Refresh Brave VPN button
  7. clicked on the VPN button
  8. hovered over the Settings icon

Confirmed the tooltip text of Settings when hovering over the Gears/Settings icon

Capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants