Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price of THOR is reporting wrong #22651

Closed
bbondy opened this issue May 2, 2022 · 3 comments
Closed

Price of THOR is reporting wrong #22651

bbondy opened this issue May 2, 2022 · 3 comments
Assignees
@onyb
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.38.x - Release #6

Comments

@bbondy
Copy link
Member

bbondy commented May 2, 2022

From community post:
https://community.brave.com/t/thor-token-on-avalanche-showing-on-ethereum-and-wrong-price/385154

It seems we have the wrong price of THOR in our wallet.

cc @onyb
@bbondy bbondy added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality feature/web3/wallet/core labels May 2, 2022
@bbondy bbondy added this to Web3 May 2, 2022
@bbondy bbondy moved this to Backlog in Web3 May 2, 2022
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. front-end-change This task is a front end task and doesn't need any C++ changes labels May 2, 2022
@onyb onyb mentioned this issue May 10, 2022
Closed
18 tasks
@onyb
Copy link
Member

onyb commented May 16, 2022 •
edited
Loading

Closed by brave-intl/bat-go#1420. Set Milestone to 1.38.x - Release #6 since the change was done to Ratios server and deployed to production.

@onyb onyb closed this as completed May 16, 2022
Repository owner moved this from Backlog to Done in Web3 May 16, 2022
@onyb onyb self-assigned this May 16, 2022
@srirambv
Copy link
Contributor

Brave 1.38.119 Chromium: 101.0.4951.67 (Official Build) (64-bit)
Revision 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS ☑️ Linux ☑️ Windows 11 Version 22H2
(Build 22598.200) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified THOR token is properly listed as THOR on Avalanche C-Chain
  • Verified price of THOR token is same as listed on CoinGecko

@LaurenWags LaurenWags mentioned this issue May 17, 2022
Closed
@Uni-verse
Copy link
Contributor

Uni-verse commented May 17, 2022 •
edited
Loading

Verified on Samsung GS21 & Samsung Tab S7 using

Brave	1.38.119 Chromium: 101.0.4951.67 (Official Build) (64-bit) 
Revision	8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS	Android 12;
  • Added Avalanche C-Chain network and imported new custom asset using the contract address published on https://www.coingecko.com/en/coins/thor
  • Verified price of THOR on our wallet matches the price on coingecko.com
market mobile mobile tablet tablet
Screen Shot 2022-05-17 at 11 10 20 AM Screen Shot 2022-05-17 at 11 04 05 AM Screen Shot 2022-05-17 at 11 03 04 AM Screen Shot 2022-05-17 at 11 16 39 AM Screen Shot 2022-05-17 at 11 16 20 AM

@kjozwiak kjozwiak mentioned this issue May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.38.x - Release #6
Development

Successfully merging a pull request may close this issue.

Add coingecko mapping for THOR token on Avalanche
4 participants
@bbondy @onyb @srirambv @Uni-verse