Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up Wallet Panel Load Time #22714

Closed
Douglashdaniel opened this issue May 6, 2022 · 1 comment · Fixed by brave/brave-core#18735
Closed

Speed up Wallet Panel Load Time #22714

Douglashdaniel opened this issue May 6, 2022 · 1 comment · Fixed by brave/brave-core#18735
Assignees
@onyb
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop perf polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Milestone
1.57.x - Release

Comments

@Douglashdaniel
Copy link

Description

Currently the Wallet Panel can takes a long time to render, the panel should be snappy and load instantly. We should investigate possible performance issues and ways to speed up the panel's load time by maybe lazy loading data so the panel can load instantly.

Screen.Recording.2022-05-05.at.8.07.49.PM.mov
@Douglashdaniel Douglashdaniel added polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. perf feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels May 6, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 7, 2022
@jamesmudgett jamesmudgett added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 7, 2022
@HEagle18 HEagle18 mentioned this issue Jun 28, 2022
Closed
@onyb onyb added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jun 16, 2023
@onyb onyb self-assigned this Jun 16, 2023
@onyb onyb mentioned this issue Jun 16, 2023
Merged
25 tasks
@onyb onyb moved this from Backlog to Done in Web3 Jun 16, 2023
@onyb onyb added this to the 1.54.x - Nightly milestone Jun 16, 2023
@onyb
Copy link
Member

onyb commented Jun 16, 2023

Fixed in brave/brave-core#18735. I created 10 EVM + 10 SVM accounts and the panel now pops up almost instantly. Closing this, but we'll keep working actively on more such improvements.

panel.perf.mov

@onyb onyb closed this as completed Jun 16, 2023
@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop perf polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

chore(wallet): improve panel performance brave/brave-core
3 participants
@jamesmudgett @onyb @Douglashdaniel